Overflow in int64 addition

YerevaNN / mimic3-benchmarks

Python suite to construct benchmark machine learning datasets from the MIMIC-III 💊 clinical database.

https://arxiv.org/abs/1703.07771

MIT License

805 stars 329 forks source link

Overflow in int64 addition #129

Closed zoevas closed 2 years ago

zoevas commented 2 years ago

By running the Step 2, I am getting an overflow error in a substract operation: ~/Downloads/mimic3-benchmarks$ python -m mimic3benchmark.scripts.extract_subjects /home/zvasilei/Downloads/mimic-iii-clinical-database-1.4 data/root

But I am getting the overflow error for the substract command in the calculation of the age in the mimic3csv.py file: Καταγραφή

diyang-lee commented 2 years ago

I also encountered the same overflow error in mimic3csv.py on MIMIC3 v1.4 dataset.

zoevas commented 2 years ago

@diyang-lee I applied the change related with stays[AGE] of this PR and the issue solved: https://github.com/YerevaNN/mimic3-benchmarks/pull/119/files

diyang-lee commented 2 years ago

thanks @zoevas , my issue solved after reset statement as well as library version.

zoevas commented 2 years ago

@diyang-lee so you did not change the code? but you changed the library versions?

diyang-lee commented 2 years ago

@zoevas I changed the code you mentioned AND library versions (in requirements.txt) in that PR.