Removes colons for normalizer filenames for windows compatibility

YerevaNN / mimic3-benchmarks

Python suite to construct benchmark machine learning datasets from the MIMIC-III 💊 clinical database.

https://arxiv.org/abs/1703.07771

MIT License

805 stars 329 forks source link

Removes colons for normalizer filenames for windows compatibility #137

Closed syfantid closed 1 year ago

syfantid commented 2 years ago

Pull request for solving issue #136 w.r.t. windows compatibility while cloning

hrayrhar commented 1 year ago

Thanks for the pull request. I have been going over and merging older pull requests. Most of the significant changes you propose are already incorporated. These include:

renaming normalizer state names to exclude colons,
using yaml.safe_load,
fixing issues related to the usage of old pandas versions,
fixing issues related to date formatting.

As for the fairness-related code, I think we should not include them to keep this main repository minimal and simple-to-use.