search

Yermo / geoPHPwithFeatures

Advanced geometry operations in PHP with Features Data
Other
5 stars 4 forks source link

Fix a bug that broke Google's GeoJSON parsing #22

Closed acorncom closed 6 years ago

acorncom commented 6 years ago

When converting from a KML file to a GeoJSON file, the coordinates array for points ended up looking like this:

[coordinates] => Array
(
  [0] => 102.595626
  [1] => 14.996729
  [2] => 
)

Feeding those results to Google Maps lead to errors. Per the GeoJSON spec, values can't be null. With this patch, coordinates come out as:

[coordinates] => Array
(
  [0] => 102.595626
  [1] => 14.996729
  [2] => 0
)

and then work properly. I'm not seeing any other tests failing, but it's possible this will cause problems for other conversions if some other formats expect a NULL value ...

Yermo commented 6 years ago

Thanks for this. I'm a little slammed right now but I am going to be working on some other issues with this library next week and will look at this then. If you don't hear from me, please ping me to remind me. Thanks!

acorncom commented 6 years ago

@Yermo I was supposed to ping you to remind you to check this ... 😉

Yermo commented 6 years ago

Thanks again for this.