Closed gnysek closed 3 months ago
Please always file an issue describing the changes you want to add before adding a PR for undocumented changes.
This is for #77
Thanks - you beat me to it, but I was about to apologise and say I realised that the contribution guidelines in the Readme were far too simplistic and so I have updated them now to be correct ;)
Yeah, there was no info about it, that's why I didn't added issue in first place :) But no problem!
I've added another test, as during checking Squirrel (-I
) version of betas, I found an interesting bug, that if there's \t
in front of Tab, macro would be converted to empty string in case of nameof()
. It's then worth to check it too in future tests, to prevent regression.
Thanks - although, if adding more tests later on, ensure you add a separate new issue and PR for just that bit rather than adding it later on into an existing PR awaiting review ;)
@gnysek apparently there are some conflicts with the dest branch, please review this PR so we can merge it
@DiasFranciscoA I'm not sure if .resource_order
file should be in this repo. It could cause problems every time that during one pull request is made, another one with another new resource(s) is merged.
I've fixed it so merged file contains all resources, then reopened project in GM, to ensure .resource_order is up to date.
Hmm that makes sense, I'll make sure .resource_order
is removed from the repo and added to .gitignore
@gnysek can you please resolve the conflicts the .resource_order
file is now out of the picture.
EDITED: Fixed locally and pushed to develop (thank you for the contribution)
Adds tests for
nameof()
(issue #77).This is a test which could be helpful after fixing https://github.com/YoYoGames/GameMaker-Bugs/issues/6506 .