[BUGFIX] Caught InvalidArgumentException within BreadcrumbStructuredDataProvider when the current site language does not exist - Githubissues

Yoast / Yoast-SEO-for-TYPO3

Yoast SEO plugin for TYPO3

Other

51 stars 56 forks source link

[BUGFIX] Caught InvalidArgumentException within BreadcrumbStructuredDataProvider when the current site language does not exist #541

Closed RinyVT closed 1 year ago

RinyVT commented 1 year ago

Summary

This PR can be summarized in the following changelog entry:

When the current site language does not exist (probably only in nested sites?), there's a InvalidArgumentException being thrown which was not caught.

Relevant technical choices:

Moved the return (string)$site->..... within the try block and added the InvalidArgumentException to be caught

Test instructions

This PR can be tested by following these steps:

Pull branch and check if the breadcrumb is still being rendered correctly

Quality assurance

[X] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #523