Sets the textdomain to the right one - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

Sets the textdomain to the right one #1153

Closed andizer closed 3 years ago

andizer commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[@yoast/schema-blocks] Changes the text domain for two strings to yoast-schema-blocks.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

Checkout this branch and do yarn build
In wordpress-seo-free link the monorepo
Do a grunt build:i18n:potFiles
In the languages directory you should have a file name yoast-schema-blocks.pot
Verify that the two string changed in this pull are present in this file. These are: hours and minutes

Impact check

This PR affects the following parts of the plugin, which may require extra testing: *

UI changes

[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #

johannadevos commented 3 years ago

CR & Acceptance: ✅