P2-860 Fixes a console warning due to an invalid key property in the VariationPickerPresenter. - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

P2-860 Fixes a console warning due to an invalid key property in the VariationPickerPresenter. #1162

Closed hansjovis closed 3 years ago

hansjovis commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[@yoast/schema-blocks] Fixes the VariationPickerPresenter: 'key' is not a prop error that was shown in the browser console when a job posting block had been added.

Relevant technical choices:

*

Test instructions

This PR can be tested by following these steps:

Create a post.
Add a job posting block.
Check the browser console, you should not see this error:
```
VariationPickerPresenter: 'key' is not a prop.
```

Impact check

This PR affects the following parts of the plugin, which may require extra testing:
- N/A.

UI changes

[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #

andizer commented 3 years ago

Acceptance 👍