P2-918 - Remove unwanted space in select instruction. - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

P2-918 - Remove unwanted space in select instruction. #1184

Closed hansjovis closed 3 years ago

hansjovis commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[@yoast/schema-blocks] Removes an unwanted trailing space in the output of the Select block instruction.

Relevant technical choices:

*

Test instructions

This PR can be tested by following these steps:

Create a post.
Add a job posting block.
Select an employment type and check one or both check boxes in the employment type's sidebar (This is an internship and/or This is a volunteer role).
Save the post.
Check the post on the frontend. It should not have whitespace after the employment type (e.g. Full time) and the other elements (e.g. this is an internship).

Impact check

This PR affects the following parts of the plugin, which may require extra testing:
- Please also check if the spacing is still correct for the base salary and salary range variations of the salary block, since both also use a select element.

UI changes

[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[ ] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #