Yoast SEO 5.3.1 breaks Ninja Forms 3.1.9 display submissions

[ghost]

The update to Yoast SE0 5.3.1 this morning broke the display submissions to Ninja Forms 3.1.9. I have deactivated Yoast SEO for now and all is working fine again in Ninja Forms.

• [x] I've read and understood the contribution guidelines.
• [x] I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

all working fine early this morning. updated the Yoast SEO plugin, then sometime later found out NF were broken when I tried to view submissions. Deactivated the SEO plugin and all works fine again.

Please describe what you expected to happen and why.

How can we reproduce this behavior?

1. 2. 3.

Technical info

Environment

Home URL: https://www.caryalliance.org Site URL: https://www.caryalliance.org Ninja Forms Version: 3.1.9 WP Version: 4.8.1 - Supported WP Multisite Enabled: No Web Server Info: Apache/2.4.7 (Ubuntu) TLS Version: unknown PHP Version: 5.5.9-1ubuntu4.22 MySQL Version: 5.5.57 PHP Locale: negative_sign: WP Memory Limit: 40M WP Debug Mode: No WP Language: Default WP Max Upload Size: 125 MB PHP Post Max Size: 125M Max Input Nesting Level: 64 PHP Time Limit: 30 PHP Max Input Vars: 1000 SUHOSIN Installed: No Server IP Address: 172.31.59.224 Host Name: ip-172-31-59-224.ec2.internal SMTP: localhost smtp_port: 25 Default Timezone: America/New_York

Plugins

Installed Plugins: Add From Server by Dion Hulse version 3.3.3 AMP by Automattic version 0.5.1 Gallery Carousel Without JetPack by Syed Balkhi version 0.7.5 Church Theme Content by churchthemes.com version 1.7.2 CryptX by Ralf Weber version 3.2.13 Glue for Yoast SEO & AMP by Joost de Valk version 0.4.2 Google Analytics Dashboard for WP (GADWP) by Alin Marcu version 5.1.1.1 Simple Calendar by Moonstone Media version 3.1.9 my_custom_change_ninja_forms_all_forms_capabilities_filter by pulled from wordpress forum version 1.0.0 Ninja Forms by The WP Ninjas version 3.1.9 RSS Via Shortcode for Page & Post by Susanta K Beura version 1.2.b Yoast SEO by Team Yoast version 5.3.1 WP-DBManager by Lester 'GaMerZ' Chan version 2.79 WP Super Cache by Automattic version 1.5.3 WP Term Order by John James Jacoby version 0.1.4

[ghost]

One more bit of info. Rolling plugin back to 5.2.0 allows Ninja Forms to work correctly.

[zachskaggs]

@yoastbot Whatever is modifying the post query here also took down all of our sales pages and documentation pages. We have lost a few thousand in sales today which I can directly attribute to upgrading from 5.2 to 5.3.2. Our sales and documentation pages were restored when we deactivated Yoast.

[kjohnson]

Confirm that this goes back to tag 5.3. This issue is not present going back to tag 5.2.

[kjohnson]

The issue seems to be introduced with 26a19fa and does not exist with the previous commit, cb94368.

[timnolte]

Opened up a ticket with Ninja Forms thinking then problem was there but they responded with this so I'm tracking this also.

[kstover]

It looks like the problem is with the commit that @kjohnson referenced above. The array_merge in the early return is always overwriting any 'meta_query' value that may be set. The array_merge should be removed and $vars should be returned instead.

[ghost]

If I could be of assistance by testing a code change, just let me know. Would be happy to help.

[ghost]

I ran the patch https://github.com/Yoast/wordpress-seo/pull/7757.patch against 5.3.2 plugin and it solved the issue of broken Ninja Forms view submissions. Thanks much!

[Pcosta88]

Please inform the customer of conversation # 217211 when this conversation has been closed.

[Pcosta88]

Above user reports it happening with Yoast SEO 5.3.2

[Pcosta88]

Please inform the customer of conversation # 217235 when this conversation has been closed.

[Pcosta88]

Above user reports

The recent update of the Yoast SEO Premium plugin from 5.2 to 5.3.1 breaks our Ninja Forms 3.1.9 display submissions

[kstover]

Any movement on this? This is a pretty big issue for our common users.

[ghost]

Hi Kevin,

The patch here: https://github.com/Yoast/wordpress-seo/pull/7757.patch https://github.com/Yoast/wordpress-seo/pull/7757.patch Seemed to solve the issue that we were seeing of the display of submissions.

Ray

On Aug 24, 2017, at 8:47:16 AM, Kevin Stover notifications@github.com wrote:

Any movement on this? This is a pretty big issue for our common users.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Yoast/wordpress-seo/issues/7750#issuecomment-324624817, or mute the thread https://github.com/notifications/unsubscribe-auth/AYO3EUz5rgMWK2NmWWXIhh5hQhjTXlcVks5sbXDUgaJpZM4O_If7.

[zachskaggs]

@Pcosta88 What are the odds of a release for this in the immediate future? This specific issue represents about 15% of our current support volume.

[cdukes]

@Pcosta88 Echoing the need for a quick fix on this. The same issue is breaking WooCommerce's admin order filtering.

Manually applying this patch on 5.3.2 worked for me, so I'm hoping the next Yoast SEO update includes a fix.

[kstover]

Unfortunately, telling our mutual users to manually install patches isn't really an option. Most of them aren't technically savvy enough to handle that, and I don't love the idea of our support techs handing out modified versions of popular plugins. We would love to see some movement on releasing a patch for this issue. It seems like it's just a simple mistake that made it in.

[ghost]

@kstover I did not mean to indicate I thought that the common users should apply the patch, I am one of those common users. I just wanted to let everyone know the patch seems to solve the problem. I also would like to see a new release of the plugin with the fix. Thanks all for the help.

[moorscode]

We are currently working on a patch release, this will be fixed today.

[moorscode]

Yoast SEO & Premium 5.3.3 have been released including a fix for this problem.