search

Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

Snippet preview: color and width props rendered as HTML attributes (invalid HTML) #559

Open afercia opened 6 years ago

afercia commented 6 years ago

Noticed a couple props are actually rendered in the HTML as (invalid) attributes:

<div class="SnippetPreview__MobileContainer-jipmEz iYVbUi" width="640" ...

<div color="#545454" class="SnippetPreview__MobileDescription-iHXWQq ...

<div color="#545454" class="SnippetPreview__MobileDescriptionOverflowContainer-OwMUS ...

Note: the MobileDescriptionOverflowContainer is going to be removed in #542

Note 2: is there any way to automate checking for props that render invalid attributes? /Cc @atimmer @Xyfi

afercia commented 6 years ago

Re-tested: as far as I see, color is gone and width is still there.