Yoctol / react-d3-cloud

A word cloud react component built with d3-cloud.
https://yoctol.github.io/react-d3-cloud
MIT License
141 stars 47 forks source link

[WIP] use withFauxDOM to handle DOM update trigger in event handlers #113

Closed chentsulin closed 3 years ago

chentsulin commented 6 years ago

https://github.com/Olical/react-faux-dom#with-animation-helper

If we want to provide some d3 feature in event handlers, for example:

function onWordMouseOver(word) {
  select(this).style('fill', 'orange');
}

We should use withFauxDOM HoC

97, #106

ismailme commented 5 years ago

Thank you @chentsulin, please let me know when the new version is available

regards

chentsulin commented 3 years ago

I just realize we should not encourage this kind of d3 side effect usage in the react-style event handlers.