YogSottot / organize-search-engines

Automatically exported from code.google.com/p/organize-search-engines
Other
0 stars 0 forks source link

Missing new line in chrome.manifest of Organize Search Engines 1.7 #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install Organize Search Engines 1.7
2. Open the error console after the start of Firefox

What do you see?
Warning: Unrecognized chrome manifest modifier 'seorganizer'.
Source file: 
<MyProfile>\extensions\organize-search-engines@maltekraus.de\chrome.manifest
Line: 18

What version of the product are you using? On what operating system and
Firefox version?
Organize Search Engines 1.7
Windows XP SP3 (Home and Professional Edition) & Ubuntu 10.04
Firefox 5.0

What other add-ons are you using?
Not necessary

Please provide any additional information below.

Line 18 of Organize Search Engines 1.7 - chrome.manifest is:
contract @mozilla.org/rdf/datasource;1?name=organized-internet-search-folders 
{f2fa3794-eb73-11db-9d18-00ffd1e32fc4}locale    seorganizer  ca-AD        
locale/ca-AD/

It should be (adding missing new line):
contract @mozilla.org/rdf/datasource;1?name=organized-internet-search-folders 
{f2fa3794-eb73-11db-9d18-00ffd1e32fc4}
locale    seorganizer  ca-AD        locale/ca-AD/

Original issue reported on code.google.com by fpi...@gmail.com on 11 Aug 2011 at 4:12

GoogleCodeExporter commented 9 years ago
fixed in revision 372:
https://code.google.com/p/organize-search-engines/source/detail?r=372

I'll try to release a new version soon.

Original comment by maltekr...@gmail.com on 25 Sep 2012 at 10:24

GoogleCodeExporter commented 9 years ago
I am not sure that this issue is fixed by chrome.manifest r372.
I think that a new line is missing at the end of this file and there is no 
difference between r351 and r372.
Then, when the first translation is added to the manifest, it is concatenated 
with the last line.

Original comment by fpi...@gmail.com on 21 Nov 2012 at 8:41

GoogleCodeExporter commented 9 years ago
Forget my comment (#2). It's really fixed.

I have just succeeded to create the xpi with r393 source (using cygwin on 
Windows XP, with little adaptations of build.sh).

Could you please put your generated xpis in downloads, to give access to more 
users ?
Or better, to submit it again to addons.mozilla.org, for a better audience and 
the automatic updates ?

Original comment by fpi...@gmail.com on 27 Nov 2013 at 11:44