search

Yomguithereal / baobab

JavaScript & TypeScript persistent and optionally immutable data tree with cursors.
MIT License
3.15k stars 117 forks source link

Bring back support for '/' in object keys. #390

Closed nivekmai closed 9 years ago

nivekmai commented 9 years ago

Just updated to 2.1.0 from 0.4.1, and realized that a bunch of my cursor listeners were not getting updates called on them.

I looked into the code, and it appears that where there used to be a λ used to build the hash, it's been changed to use /.

As such, any object that has / in it's keys can not listen to updates.

It's a pretty simple fix (just change / to λ in a couple places), but I'm thinking this may have been done for a reason. If not, could you change it back to use λ instead? / is a pretty common character, and is a bit annoying to not be able to use.

nivekmai commented 9 years ago

Created a pull request to fix this, #392.

Yomguithereal commented 9 years ago

Continuing this discussion on #392 :smile:.