search

YorffoeG / diyscip

DIY Supervision and Control Intxx PxxxSPA with an ESP8266
Other
42 stars 18 forks source link

Button push by software #3

Closed UlrichMai closed 4 years ago

UlrichMai commented 4 years ago

Thanks YorffoeG for that fine hardware solution and well structured code. I can still learn a lot from your coding style.

I developed a solution in the past month, that solved the problem to simulate the button push by software and does not need pcb and custom build connectors. I tried to integrate my solution in you code using an new PCB_DESIGN_3. I needed to restructure the #ifdefs a bit. I hope I did not break the other 2 PCB_DESIGNs. I added link in readme to my "hardware" wiring.

My solution is running very stable in my pool since several days. Let my know, if you like to integrate my code into your solution. This is my first contribution ever. So I hope I did not break any rule or offend you.

Ulrich

dvoc commented 4 years ago

Interesting UlrichMai, then if I understood well PCB_DESIGN_3 only needs an Esp8266 mini D1, one diode and two resistors and it's fully compatible with diyscip software? I have seen your homekit integration but I prefer an mqtt integration (for Homeassistant). Rgds.

UlrichMai commented 4 years ago

Interesting UlrichMai, then if I understood well PCB_DESIGN_3 only needs an Esp8266 mini D1, one diode and two resistors and it's fully compatible with diyscip software?

Yes, these are the only components you need. You can omit the wire with the100Ohm resistor. It controls the buzzer, which is currently not used by this implementation. Let me know, if it is working for you. Ulrich

YorffoeG commented 4 years ago

Hi Ulrich,

Thanks for your contribution, It was my first idea "pushing button" by software. But from my tests it was not enough reliable in my opinion but i will re-considerer my idea by testing your work. You may also have some electrical issues, esp8266 works with CMOS signal, SPA with TTL.

We keep in touch :-) Geoffroy

UlrichMai commented 4 years ago

I am also interested in your comments on the coding style. Yours is so much better than mine and I hope you will merge my stuff some time. You already started adding code for the SJB_HS models. I am in touch with @red-gee to make his pool work too. We should have started the discussion in context of your project, or at least in my fork of you project, but it is currently here. And I have created a branch support-saltwaterspa for this. This is my first github project. Please let me know if it is ok how we handle this fork/branch/push thing, or you would like to handle it different? Ulrich

red-gee commented 4 years ago

For now the version with pcb 3 works without problems.