search

Yortw / RSSDP

Really Simple Service Discovery Protocol - a 100% .Net implementation of the SSDP protocol for publishing custom/basic devices, and discovering all device types on a network.
http://yortw.github.io/RSSDP/
MIT License
282 stars 66 forks source link

Newlines are not sent #108

Closed sandromastronardi closed 3 years ago

sandromastronardi commented 3 years ago

I tried making my own virtual device but i could not get it to work, when I used the uPnP sniffer i noticed why... my NOTIFY packages are sent without newlines while others do have newlines...

https://github.com/Yortw/RSSDP/blob/53ce402409cb774e288ac99a028bc81e4537e53f/src/Main/Rssdp.Shared/SsdpDevicePublisherBase.cs#L48

I noticed the locator uses \r\n but here it is just a newline in the literal, an I think GIT replaces them with \n on check-in and maybe when you build on Linux (or some other reason) they are not reinstated and thus the package does not send the notifications correct?

sandromastronardi commented 3 years ago

ok, I was using this library for the net framework and the Rssdp.NetStd for .net core... it appears to be there not here...