row indices of NA observations in error message

YosefLab / scone

53 stars 12 forks source link

row indices of NA observations in error message #94

Open idot opened 6 years ago

idot commented 6 years ago

adds indices of genes failing filtering to error message

drisso commented 3 years ago

Hi @idot ,

thanks for the PR and sorry for not responding earlier, I hope this is still relevant and you are still willing to contribute.

Your PR would not work if pos_controls is a character vector. Can you please edit it so that it would? Also, it would be good to avoid 1:nrow(expr) and use seq_len(nrow(expr)) instead.