[StaticScan] Changes due to minor issues found by static scan

[estess]

Modules changes:

• sr_port/bm_getfree.c

  • Initialize 'depth' to zero

• sr_port/dse_m_rest.c

  • Some reformats due to non-standard formatting pre-existing.
  • The variable r_top was initialized further down so line 93 was not necessary.

• sr_port/dse_shift.c

  • Initialize 'lbp' to NULL earlier so no paths to it being undefined.

• sr_port/gtmsource_ctl_init.c

  • Free 'tmp_ctl' when returning or erroring out.

• sr_port/is_canonic_name.c

  • Remove variable 'seq' which is not used and may have issues dereferencing 'subscripts' when not provided.

• sr_port/mu_int_blk.c

  • Free malloc'd storage (in 'free_blk_base') before return.

• sr_port/mupip_set_journal.c

  • Remove unused gds_info allocation (not plugged into anything) and changed entire clause to FILE_CNTL_INIT_IF_NULL() macro to do initialization correctly.

• sr_port/mur_output_show.c

  • Initialize 'first_time' to TRUE so no path to it being uninitialized.

• sr_port/op_fnzsocket.c

  • Move initialization of 'tls_options_mask' up earlier so no paths to uninitialized use.

• sr_port/op_indincr.c

  • Only do put_tref() if something to put.

• sr_port/restrict.c

  • Not sure why this is here. This module shows as identical to the one in V999 (current mainline). This project has no changes here.

• sr_port/stp_gcol_src.h

  • Make sure cstr is initialized in both stp_gcol and stp_move paths.

• sr_port/tcp_open.c

  • Remove some old Tru64 stuff.
  • Remove unnecessary initialization of remote_ai_ptr.
  • Remove some unused variables.
  • Move client initialization to client section.
  • Change close() to CLOSEFILE() macros.
  • Make sure to release block chain at ai_ptr.
  • Remove assert when erroring with timeout (now tested by online_bkup/online6).
  • Make sure release block chain at remote_ai_head.

• sr_unix/anticipatory_freeze.c

  • Add an FCLOSE() and error check for same prior to module returns.

• sr_unix/bin_load.c

  • Implement mechanism to track all of the allocated buffers and free any that were allocated on an error.

• sr_unix/cli_lex.c

  • Make sure return value is null when nothing is read.

• sr_unix/gtm_getpwuid.c

  • Removed an unneeded return value check from malloc (gtm_malloc does not return if no storage).
  • Reformatted an #ifdef block.
  • The original static-scan change released the 'buff' variable it was complaining about but that free was removed as it needs to be there for all subsequent calls to this routine.

• sr_unix/gtmcrypt_entry.c

  • Only do the loop to dump the streams if the journal pool exists.

• sr_unix/gtmsecshr.c

  • Close 'procstrm' before return on error.

• sr_unix/gtmsource_shutdown.c

  • Add '!auto_shutdown' as 'maxindex' is only set when !auto_shutdown.

• sr_unix/iosocket_tls.c

  • Errors aren't using the correct method of getting error out there. The 'errlen' var is only seldomly set.

• sr_unix/mu_all_version_standalone.c

  • Save 'errno' to 'save_errno' for the error message.

• sr_unix/mucblkini.c

  • Free 'bp1' and 'bp2' appropriately before leaving routine.

• sr_unix/op_zlink.c

  • Move initialization of 'srcstr' closer to where used and only for those options where srcnamelen is set.

• sr_unix/relinkctl.c

  • Add error checks and messages for SHMDT invocations.
  • Initialize 'shm_hdr' to prevent usage when is still uninitialized.

• sr_unix/ss_anal_shdw_file.c

  • Make sure malloc'd 'bitmap_buffer' is released before return.

• sr_unix/trigger_source_read_andor_verify.c

  • Initialize 'rttabent' to NULL
  • If not initialized, set 'rttabent' to our rtn_names list.

• sr_unix/util_output.c

  • Add default clause to switch with an assert in it. Still doesn't prevent static scan issue but next time through it can be marked ignorable.

• sr_unix/wait_for_disk_space.c

  • Add a default for 'freeze_cleared' so is initialized.

• sr_unix_cm/gtcm_bgn_net.c

  • Release 'ai_ptr' block chain before return.

• sr_unix_cm/gtcm_init.c

  • Define OMI_FREE() macro for better cleanup. Add to any place before error or return
  • Initialize 'agname' and 'ag_pass'.
  • Remove clauses that test memory allocation result. Note gtm_malloc() does not return if allocation fails.

• sr_unix_cm/rc_srvc_xct.c

  • Added a macro to do the cleanups and added it before return points.

• sr_unix_gnp/cmi_init.c

  • Some minor formatting changes for code standards.
  • Make sure local_ai_ptr block chain is freed before leave routine.

• sr_unix_gnp/cmi_open.c

  • Some minor formatting changes for code standards.
  • Make sure ai_head block chain is freed before leave routine.

• sr_unix_gnp/cmj_get_port.c

  • Removed - no users of this routine were found.

• sr_unix_gnp/cmj_getsockaddr.c

  • Make sure ai_ptr block chain is freed before leave routine.

• sr_unix_gnp/cmj_getclb.c

  • Make sure ai_ptr block chain is freed before leave routine.

• sr_unix_gnp/gtcm_gnp_server_main.c

  • Change static routines to STATICFN{DCL,DEF}.
  • The 'status' variable was not set until after it was referenced. Removed the test of the uninitialized status.