YouROK / TorrServer

Torrent stream server
GNU General Public License v3.0
1.61k stars 202 forks source link

[BUG] DLNA Doesn't work #447

Closed Andrewkha closed 2 months ago

Andrewkha commented 3 months ago

Describe the bug DLNA feature is enabled in TorrServer MatriX.133t features (running in official docker container), but DLNA is not visible over network To Reproduce Steps to reproduce the behavior:

  1. Go to Settigns - Additional - DLNA Media Server
  2. Click on toggle button to enable DNLA, set a custom DLNA server name
  3. See error - no error is observed, just DLNA media doesn't appear in the network

Expected behavior I expect DLNA server to be available over network (worked previously)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone or tvbox on Android (please complete the following information):

Additional context Add any other context about the problem here.

ddonindia commented 2 months ago

DLNA with docker needs host networking. Try passing --network=host in your docker run command

Andrewkha commented 2 months ago

@ddonindia thanks, this solved the original issue, but created another one - Torrserver web interface stopped working. Here's my docker-compose.yaml

version: '3.3'
services:
    torrserver:
        image: ghcr.io/yourok/torrserver
        network_mode: "host"
        container_name: torrserver
        environment:
            - TS_PORT=5665
            - TS_DONTKILL=1
            - TS_HTTPAUTH=0
            - TS_CONF_PATH=/opt/ts/config
            - TS_TORR_DIR=/opt/ts/torrents
        volumes:
            - '/share/CACHEDEV1_DATA/Container/container-station-data/app_data/torrserver_data/CACHE:/opt/ts/torrents'
            - '/share/CACHEDEV1_DATA/Container/container-station-data/app_data/torrserver_data/CONFIG:/opt/ts/config'
        ports:
            - '8090:5665'
        restart: unless-stopped
Andrewkha commented 2 months ago

@tsynik can you, please, elaborate what "not planned" means? There's a feature and it doesn't work. Is this smth documented that I just wasn't able to find?

tsynik commented 2 months ago

It's not a question of torrserver and not a bug. DLNA works on local network and in case of Android till Android 13. We not planning changing anything in DLNA code.

Andrewkha commented 2 months ago

@tsynik sorry, I do not understand your point... There's feature in Torrserver to enable DLNA and it doesn't seem to work, there's nothing about Android here... Like I said, I'm running Torrserver in container on Ubuntu, I switch on the DLNA server option in Torrserver. When I turn on a DLNA player on the same network, it doesn't discover the Torrserver's DLNA. When I tried the solution @ddonindia recommended above, the DLNA server appeared on the network, however torrserver's web interface became unavailable

tsynik commented 2 months ago

When I tried the solution @ddonindia recommended above, the DLNA server appeared on the network, however torrserver's web interface became unavailable

Once again: it's not a TorrServer bug but your bad network knowledge skills. Docker is not part of torrserver and have it's own support.

https://github.com/YouROK/TorrServer/issues/449

Andrewkha commented 2 months ago

@tsynik

Once again: it's not a TorrServer bug but your bad network knowledge skills.

I do not argue that at all... But imagine I'm an average user. I install the software, see the feature and just want it working. If it doesn't and there's no anything about that in documentation I obviously treat this as a bug. If some additional configuration is required to make it working it would be nice if you could mention this in the "Running in Docker & Docker Compose" section of readme, especially there's a docker compose file example. Like "if you want DLNA working in a container installation do this and this" But again, once I applied the solution you mentioned in https://github.com/YouROK/TorrServer/issues/449 Torrserver's web interface stopped working. Is it expected or I did smth wrong? Anyway if there's something special about a feature working in a certain distribution type it's worth mentioning this in readme

Andrewkha commented 2 months ago

BTW, I resolvd the issue. Adding network_mode: host really makes the web interface unavailable but only if non-standard port mapping is used (like it was in my case 8090:5665). When I switched to 5665:5665 everything is working

TopperBG commented 2 months ago

BTW, I resolvd the issue. Adding network_mode: host really makes the web interface unavailable but only if non-standard port mapping is used (like it was in my case 8090:5665). When I switched to 5665:5665 everything is working

Suggest PR with actual README.md then ;)

ddonindia commented 2 months ago

@Andrewkha in docker port mapping doesn't work with host networking mode(docker compose will give you this in warning as well). If you want to change port change TS_PORT to corresponding value and it should work.

Andrewkha commented 2 months ago

@Andrewkha in docker port mapping doesn't work with host networking mode(docker compose will give you this in warning as well). If you want to change port change TS_PORT to corresponding value and it should work.

@ddonindia yeah, I now realized that. Thanks for help!