Potential removal of webauthn_json_mapping?

Yubico / python-fido2

Provides library functionality for FIDO 2.0, including communication with a device over USB.

https://developers.yubico.com/python-fido2/

BSD 2-Clause "Simplified" License

439 stars 109 forks source link

Potential removal of webauthn_json_mapping? #241

Closed koalo closed 1 week ago

koalo commented 1 week ago

Hi, I just noticed that 023e880 has introduced the statement "# TODO 2.0: Remove this feature" for webauthn_json_mapping. What is the reason for that @dainnilsson ? Especially since browsers have just introduced parseRequestOptionsFromJSON(): https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential/parseRequestOptionsFromJSON_static

Thanks, Florian

koalo commented 1 week ago

Sorry, just stumbled upon https://github.com/Yubico/python-fido2/issues/169#issue-1519010262 So apparently I just misread your comment and thought you want to remove JSON support instead of making it default. Sorry!

dainnilsson commented 1 week ago

No worries, and you are correct: Starting with version 2.0 the feature toggle will be removed, and the JSON-compatible dict serialization will be the standard behavior.