search

YunoHost-Apps / discourse_ynh

Discourse package for YunoHost
https://www.discourse.org/
GNU General Public License v2.0
24 stars 12 forks source link

V.2.5.4 #61

Closed ericgaspar closed 4 years ago

ericgaspar commented 4 years ago

Problem

Solution

PR Status

Package_check results

Build Status

Add this is the output of package_check on my server...

Package linter:                  SUCCESS
Installation:                    SUCCESS
Deleting:                        SUCCESS
Installation in a sub path:      SUCCESS
Deleting from a sub path:        SUCCESS
Installation on the root:        SUCCESS
Deleting from root:              SUCCESS
Upgrade:                         SUCCESS
Installation in private mode:    SUCCESS
Installation in public mode:     SUCCESS
Multi-instance installations:    FAIL
Malformed path:                  Not evaluated.
Port already used:               Not evaluated.
Backup:                          SUCCESS
Restore:                         SUCCESS
Change URL:                      SUCCESS
Actions and config-panel:        Not evaluated.
JimboJoe commented 4 years ago

Hi, what was wrong with this PR... ?

ericgaspar commented 4 years ago

Hi, what was wrong with this PR... ?

Hi, I wanted to know more about the fact that the jenkins CI completely fails the tests while on my server the tests pass (I am re-running now tests so I can share whats passing and failling on my CI*)… maybe I could reopen the PR so someone can test it on is own machine?

After 6 hours and 15 minutes of tests @@ the Multi-instance installations* test fails...

JimboJoe commented 4 years ago

The multi-instance test usually fails on my dev server due to the lack of free memory.

ericgaspar commented 4 years ago

The multi-instance test usually fails on my dev server due to the lack of free memory.

How much RAM does your dev server have? (mine has 8 GB ...)

JimboJoe commented 4 years ago

Small VM with 2GB RAM :wink:

ericgaspar commented 4 years ago

Made a small update and retry a test 💤 Still failling at the same place: Multi-instance -> sous.domain.tld/path

Multi-instance installations

Try to access by url...
Test url: sous.domain.tld/path
Real url: https://sous.domain.tld/path
HTTP code: 502
The HTTP code show an error.
Title of the page:
Extract of the page:
                               502 Bad Gateway
     __________________________________________________________________

                                    nginx

Test url: sous.domain.tld/path/
Real url: https://sous.domain.tld/path/
HTTP code: 502
The HTTP code show an error.
Title of the page:
Extract of the page:
                               502 Bad Gateway
     __________________________________________________________________

                                    nginx
JimboJoe commented 4 years ago

Hi, I updated to 2.5.2 and fixed multi-instance mode by using a recent parameter (UNICORN_LISTENER) to set properly to socket communication (was priorly "patched" and here it was failing because it reverted to TCP port and it created a conflict on port 3000). Can you have a try on your side please?

EDIT: btw, package_check ongoing here: https://ci-apps-dev.yunohost.org/jenkins/job/discourse_ynh%20(JimboJoe)/1/ EDIT2: Errno::EDQUOT: Disk quota exceeded How can we work around this on the CI?

ericgaspar commented 4 years ago

Yeaa \o/ I got no failing on my server CI.

Package linter:                  SUCCESS
Installation:                    SUCCESS
Deleting:                        SUCCESS
Installation in a sub path:      SUCCESS
Deleting from a sub path:        SUCCESS
Installation on the root:        SUCCESS
Deleting from root:              SUCCESS
Upgrade:                         SUCCESS
Installation in private mode:    SUCCESS
Installation in public mode:     SUCCESS
Multi-instance installations:    SUCCESS
Malformed path:                  Not evaluated.
Port already used:               Not evaluated.
Backup:                          SUCCESS
Restore:                         SUCCESS
Change URL:                      SUCCESS
Actions and config-panel:        Not evaluated.
ericgaspar commented 4 years ago

@JimboJoe Shall we merge?

JimboJoe commented 4 years ago

I just tried an upgrade on my 2.3.10 version. It failed on ruby-build installation: https://paste.yunohost.org/raw/ubebelovok

JimboJoe commented 4 years ago

I upgraded to 2.5.4 and fixed an issue with older installations with outdated ruby-build plugin lacking ruby 2.7.0. Should be OK now. Wanna give it a last try, @ericgaspar ?

ericgaspar commented 4 years ago

@JimboJoe I finally manage to run the package_check tests to the end and it does not report any error.

JimboJoe commented 4 years ago

Then maybe it's TIIIME TO RELEAAASE?