Request Entity Too Large & upgrade

[farvardin]

Describe the bug

• the client_max_body_size option in /etc/nginx/conf.d/domain.d/gitea.conf is maybe too small by default (200M), resulting in errors while pushing images
• changing this to something higher is replaced back to default after an upgrade of the yunohost gitea package

Expected behavior

• in the case someone customise the /etc/nginx/conf.d/domain.d/gitea.conf it should maybe not be replace by the default one after an upgrade...

[Josue-T]

Hello,

Normally it's expected that the user don't customize config file managed by the app. So it's not an issue but the expected comportment.

Now, I would like to know which file is too big to exceed 200M. We can change this parameter if it make sense.

[farvardin]

Now, I would like to know which file is too big to exceed 200M. We can change this parameter if it make sense.

hello, it's quite common to build docker images which are higher than 1 Gb (in actions), and then we need to push them in the packages repository, which fail because of the client_max_body_size. I suppose increasing the value won't suit people which are not using packages, and even increasing by default to 1 Gb wouldn't be enough for some other people (we often increase it to more than 3 Gb). I guess I'll have to change the values after each new upgrade...

[Josue-T]

In this case it should be better to just put client_max_body_size=0 so it mean infinite.

[stilobique]

We can expose this setup inside the yunohost webadmin ? I can try to make a PR.

[farvardin]

In this case it should be better to just put client_max_body_size=0 so it mean infinite.

now that's interesting, but if it was made this way for everyone, wouldn't it there a risk to crash something for other people if a ressource is too hungry?

@stilobique sure, such an option (a value to enter, or "unlimited") within the yunohost webadmin would probably be the best!

[Josue-T]

Honestly I'm not sure that adding a specific settings in the control panel is the best solution. For not technical people a setting like this is quite confusing. For some others app I already set this to 0 avoid any issues and I didn't had any bad feedback about this.

[farvardin]

@Josue-T I don't understand why "non technical people" would need to use gitea, honestly... I suppose it should be either modified to use unlimited (set it to 0) or to add an option on yunohost admin.

I've upgraded the latest gitea and forget about this issue, I've encountered the problem again (docker images are often more than 200 Mb....)