HedgeDoc edit note icon redirect on https://hedgedoc/s/ without yunohost domain

Doctor-Who commented 2 years ago

HedgeDoc edit note icon redirect on https://hedgedoc/s/ without yunohost domain

On publish view, when trying to click on edit button (the pen icon), url is wrong and not integrate domain. URL is : https://hedgedoc/s/*********/edit instead https://domain.com/hedgedoc/s/*********/edit

Context

Hardware: Raspberry Pi 3B Plus
YunoHost 4.3.6.2 (stable)
I have access to my server: Through SSH | Through the webadmin
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: No
Using, or trying to install package version/branch: 1.9.1~ynh1

Steps to reproduce

In the note edition :

Go to Publish option
On Published view, try to edit note (pen icon)

URL is wrong

Expected behavior

Should redirect to the source note.

Logs

No log error :/

Doctor-Who commented 2 years ago

By editing config.json and fix the double /, URL is good. So fixing issue #19 will also fix this one #38

ericgaspar commented 2 years ago

@Doctor-Who Can you be more specific about what you changed in config.json?

Edit: Also I think that removing the trailing slash from path as been fixed in the install script. My guess is that as we keep the config file during upgrade, the fix has not been properly populated... https://github.com/YunoHost-Apps/hedgedoc_ynh/blob/ec76e11cccdd3bd59f08e8b6f0e12b7f83785507/scripts/install#L136

Doctor-Who commented 2 years ago

@ericgaspar thanks for you reply.

I've edit config.json on line 6 as follow :

Change "urlPath": "/hedgedoc" With "urlPath": "hedgedoc"

ericgaspar commented 2 years ago

Thanks for your help on pointing this out. I was trimming the trailing slash instead of leading slash :/ Fix is on its way

ericgaspar commented 2 years ago

Closing with #40

YunoHost-Apps / hedgedoc_ynh