search

YunoHost-Apps / libreto_ynh

LibreTo package for YunoHost
http://libreto.net/
GNU Affero General Public License v3.0
6 stars 5 forks source link

Upgrade broke the app #23

Open rodinux opened 1 year ago

rodinux commented 1 year ago

Describe the bug

Upgrading to 0.0.20180605~ynh5 from 0.0.20180605~ynh4 broke the app

Context

Steps to reproduce

Expected behavior

Upgrade and keep the app working as it was

Logs

Some logs here

cat /var/log/nginx/libreto.mydomain.tld-error.log.1
2023/08/12 16:14:38 [error] 2953587#2953587: *295132 FastCGI sent in stderr: "PHP message: PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/libreto/libreto/vendor/Markdownify/src/Converter.php on line 347" while reading response header from upstream, client: 2a01:e0a:94:50:a85f:fed6:7950:c763, server: libreto.mydomain.tld, request: "GET / HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm-libreto.sock:", host: "libreto.mydomain.tld", referrer: "https://mydomain.tld/"
2023/08/12 16:35:09 [error] 2967252#2967252: *125 FastCGI sent in stderr: "PHP message: PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/libreto/libreto/vendor/Markdownify/src/Converter.php on line 347" while reading response header from upstream, client: 2a01:e0a:94:50:a85f:fed6:7950:c763, server: libreto.mydomain.tld, request: "GET / HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm-libreto.sock:", host: "libreto.mydomain.tld", referrer: "https://mydomain.tld/"
2023/08/12 16:48:31 [error] 2270#2270: *14 FastCGI sent in stderr: "Primary script unknown" while reading response header from upstream, client: 2a01:e0a:94:50:a85f:fed6:7950:c763, server: libreto.mydomain.tld, request: "GET / HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm-libreto.sock:", host: "libreto.mydomain.tld", referrer: "https://mydomain.tld/"
2023/08/12 16:48:49 [error] 2270#2270: *14 FastCGI sent in stderr: "Primary script unknown" while reading response header from upstream, client: 2a01:e0a:94:50:a85f:fed6:7950:c763, server: libreto.mydomain.tld, request: "GET / HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm-libreto.sock:", host: "libreto.mydomain.tld", referrer: "https://mydomain.tld/"
2023/08/12 16:59:10 [error] 7457#7457: *72 FastCGI sent in stderr: "PHP message: PHP Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/libreto/libreto/vendor/Markdownify/src/Converter.php on line 347" while reading response header from upstream, client: 2a01:e0a:94:50:a85f:fed6:7950:c763, server: libreto.mydomain.tld, request: "GET / HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.4-fpm-libreto.sock:", host: "libreto.mydomain.tld", referrer: "https://mydomain.tld/"

I had remove the app reinstall the pre-upgrade backup.

rodinux commented 12 months ago

I still can't upgrade Libreto, nobody have also this issue ??

rodinux commented 12 months ago

Ok, I found the issue, for me the issue is because of this commit: https://github.com/YunoHost-Apps/libreto_ynh/commit/b9b368774eaf47608127a39fd71935be54d30991

editing the file libreto.conf with

  location /libreto/assets/ {
     alias /var/www/libreto/libreto/assets/;
  }

resolve the issue !

Lab-8916100448256 commented 3 months ago

I'm facing the same issue after a fresh install of libreto. Editing the libreto.conf file the same as you also resolved the issue for me. As the commit that caused this is the only thing in the PR that was merged at that time there must have been an issue resolved by that commit.