search

YunoHost-Apps / mautrix_signal_ynh

Matrix signal package for YunoHost
GNU Affero General Public License v3.0
4 stars 10 forks source link

Bullseye #45

Closed Gredin67 closed 2 years ago

Gredin67 commented 2 years ago

Problem

Solution

PR Status

Package_check results

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

Build Status

Gredin67 commented 2 years ago

As far as I understood it was solved upstream. But it was not tested thoroughly yet. That's why I would keep these comments for now. We can remove it in a later release.

Le 21 avril 2022 16:29:40 GMT+02:00, Mayeul Cantan @.> a écrit : @. commented on this pull request.

@@ -115,7 +113,7 @@ ynh_script_progression --message="Configuring system user..." --weight=1

Add the user to the signald group. The signald group was created when

the signald

package was installed from the extra repository

resolved by

https://gitlab.com/signald/signald/-/commit/278240f3f1cc40a3b444c958b68ca3d6908e98a8 -ynh_system_user_create --username=$app --groups="$signald_user" +ynh_system_user_create --username=$app

Why remove signald group membership? This will cause permissions issues when accessing the socket.

If that's needed, also remove the comment l.113

-- Reply to this email directly or view it on GitHub: https://github.com/YunoHost-Apps/mautrix_signal_ynh/pull/45#pullrequestreview-948717299 You are receiving this because you authored the thread.

Message ID: @.***>

-- Envoyé depuis /e/ Mail.

Gredin67 commented 2 years ago

!bullseyetestme

yunohost-bot commented 2 years ago

[Bullseye :horse:] :carousel_horse: Test Badge

nathanael-h commented 2 years ago

Hello, for your information, I tried this branch (update). The script ran well. But I have this errors in logs :

juil. 05 18:51:24 python3[3316326]: [2022-07-05 18:51:24,123] [ERROR@mau.portal.mCeel9JFVBzMxxxxxxxxpAQ03LUD3x/jBtY=] Failed to update portal
juil. 05 18:51:24 python3[3316326]: Traceback (most recent call last):
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mautrix_signal/portal.py", line 1536, in update_matrix_room
juil. 05 18:51:24 python3[3316326]:     await self._update_matrix_room(source, info)
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mautrix_signal/portal.py", line 1595, in _update_matrix_room
juil. 05 18:51:24 python3[3316326]:     await self.update_info(source, info)
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mautrix_signal/portal.py", line 1300, in update_info
juil. 05 18:51:24 python3[3316326]:     await self._update_participants(source, info)
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mautrix_signal/portal.py", line 1451, in _update_participants
juil. 05 18:51:24 python3[3316326]:     await source.sync_contact(address)
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mautrix_signal/user.py", line 295, in sync_contact
juil. 05 18:51:24 python3[3316326]:     profile = await self.bridge.signal.get_profile(
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mausignald/signald.py", line 398, in get_profile
juil. 05 18:51:24 python3[3316326]:     resp = await self.request_v1(
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mausignald/rpc.py", line 244, in request_v1
juil. 05 18:51:24 python3[3316326]:     return await self._request(command, expected_response=command, version="v1", **data)
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mausignald/rpc.py", line 238, in _request
juil. 05 18:51:24 python3[3316326]:     resp_type, resp_data = await self._raw_request(command, **data)
juil. 05 18:51:24 python3[3316326]:   File "/opt/yunohost/mautrix_signal/lib/python3.9/site-packages/mausignald/rpc.py", line 235, in _raw_request
juil. 05 18:51:24 python3[3316326]:     return await asyncio.shield(future)
juil. 05 18:51:24 python3[3316326]: mausignald.errors.ResponseError: ProfileUnavailableError: profile unavailable

Jul 05 18:55:01 aaaaa.fr python3[3316326]: [2022-07-05 18:55:01,879] [WARNING@mausignald] Error reading message from +336xxxx9/1 (timestamp: 1656679181036, content hint: 1): org.signal.libsignal.metadata.ProtocolInvalidMessageException: org.signal.libsignal.protocol.InvalidMessageException: invalid Whisper message: decryption failed

In element I see this : image

Gredin67 commented 2 years ago

@nathanael-h did you try a fresh install or an upgrade? I guess you are on bullseye, right? I will merge this in testing for now, we can continue discussing on testing before merging into master

MayeulC commented 2 years ago

Q: what happens if someone on Debian 10 installs this?

Gredin67 commented 2 years ago

now he can't. I already left a branch buster in case someone wants to.