Remove client.conf.tpl from /etc/openvpn

[hidrarga]

Problem

The way we upgrade the client config is confusing:

1. We backup both the config files (client.conf, client.ovpn, client.cube) and the template (client.conf.tpl) in /etc/openvpn
2. We upgrade the template at /etc/openvpn/client.conf.tpl
3. In case the client.cube file exists, we apply the template in ./conf/openvpn_client.conf.tpl (not the one from /etc/openvpn)
4. We restore the template /etc/openvpn as it was in step 1.
5. We replace the config file with the one we upgraded (= we applied the new template on it)

At first, I thought the template in /etc/openvpn was never upgraded (which is the case), but actually it's never used at all!

Solution

My solution is to remove the template in /etc/openvpn.

PR Status

• [x] Code finished and ready to be reviewed/tested
• [x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[hidrarga]

!testme

[yunohost-bot]

Living in the future, are we?

[yunohost-bot]

Living in the past, are we? :cow::eye:

[hidrarga]

!testme

[yunohost-bot]

Living in the future, are we?