Fix services not restarting when the UI updates the conf - Githubissues

YunoHost-Apps / wireguard_ynh

WireGuard VPN software with a web UI configuration companion, packaged for YunoHost.

GNU General Public License v3.0

35 stars 10 forks source link

Fix services not restarting when the UI updates the conf #55

Closed Tagadda closed 2 years ago

Tagadda commented 2 years ago

Problems and solutions

This aims to fix #49 ! But with every solution, comes a new problem, so here's a list of "Problem : solution", chronologically :

wireguard@.service will stay active after exit, preventing the path to start it again : remove RemainAfterExit.
wireguard@.service have an ExecStop command, which will run every time after startup if it doesn't RemainAfterExit : remove the ExecStop.
wireguard@wg0.service can't be stopped from yunohost service stop or the webadmin : change the service integration to use directly wg-quick@wg0.service instead.

PR Status

~~This needs to be tested manually.~~ Manually tested and working great o/

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

tituspijean commented 2 years ago

Thank you so much! I felt like I dug my own grave with all these services. xD I'll merge now and actually test in #56.