search

ZJONSSON / node-etl

npm install etl
233 stars 49 forks source link

used latest version of mongodb for tests bec of npm audit vulnerability #100

Closed montumodi closed 4 years ago

montumodi commented 5 years ago

used latest version of mongodb for tests bec of npm audit vulnerability. Although it is in dev dependecy so doesn't really impact any one but still if someone is planning to do some dev on local, it will throw error.

montumodi commented 5 years ago

I am not sure why but tests are breaking when they run in context of docker. If I run them directly from my mac book, they are fine. Not sure what is wrong.

montumodi commented 5 years ago

@ZJONSSON The tests are fine now. If you are happy to merge it.

ZJONSSON commented 5 years ago

Thanks @montumodi excellent - can you confirm if this is a breaking change? (i.e. whether we bump major/minor/patch)

montumodi commented 5 years ago

@zjonsson We should be ok as I have just changed tests i.e dev dependency.

Also if you see mongo driver 2 and 3 are backward compatible. https://docs.mongodb.com/ecosystem/drivers/driver-compatibility-reference/#node-js-driver-compatibility

montumodi commented 4 years ago

@ZJONSSON Did you get a chance to look in to this? I hope my reply has answered your query

montumodi commented 4 years ago

@ZJONSSON checking again to see if this PR is all good to be merged.

ZJONSSON commented 4 years ago

published as + etl@0.6.12 thanks @montumodi @jbreckman