search

ZJUSCT / mirror-front

ZJU mirror front-end
https://mirrors.zju.edu.cn
MIT License
32 stars 7 forks source link

Migrate from gatsby-plugin-react-helmet to Gatsby Head API #40

Closed RalXYZ closed 1 year ago

RalXYZ commented 1 year ago

The gatsby-plugin-react-helmet package will be deprecated in the future. Gatsby adds Head API in gatsby@4.19.0, and the official doc suggests to use it.
Our gatsby-plugin-react-helmet is added in https://github.com/ZJUSCT/mirror-front/commit/e67c3874c3ff0fab65a67278347809910785f25c by @HowyoungZhou .

iamNCJ commented 1 year ago

Removed this plugin in a532f9f by copying the Helmet source from gatsby-plugin-react-i18next, which introduced the dependency to this plugin. Also bumped gatsby-plugin-react-i18next to the latest version. The react-helmet package is still kept because it's still used by gatsby-theme-material-ui-top-layout.

iamNCJ commented 1 year ago

Currently the SEO part is functionally working, but we still need some typing expert to add types to all these untyped code...

iamNCJ commented 1 year ago

BTW, the theme-color meta info is relevant to #30