ZLMediaKit / ZLMediaKit

WebRTC/RTSP/RTMP/HTTP/HLS/HTTP-FLV/WebSocket-FLV/HTTP-TS/HTTP-fMP4/WebSocket-TS/WebSocket-fMP4/GB28181/SRT server and client framework based on C++11
https://docs.zlmediakit.com
Other
14.58k stars 3.55k forks source link

[BUG] on_play 的 webhook 参数 schema 有误或与文档不符 #4133

Closed ixugo closed 2 days ago

ixugo commented 3 weeks ago

Phenomenon Description

您好,我正在开发 github.com/gowvp/gb28181 项目,在对接 webhook 的过程中遇到一点疑惑。

  1. rtmp 推流到平台
  2. 用 flv 协议播放
  3. webhook 的 on_play 回调 schema 值始终是 rtmp,我阅读文档后期望的值是 httpflv

文档中关于此参数的原文是 播放的协议,可能是 rtsp、rtmp、http,那播放用 http flv 协议,是不是应该 schema=http

如果播放 flv 的 on_play 中 schema=rtmp,那文档上的描述是否应该更正为 推流的协议,可能是 rtsp、rtmp... 等更准确的描述。

How to reproduce?

  1. rtmp 推流
  2. flv 协议播放
  3. 检查 on_play 回调的 schema 值

Related logs or screenshots

Image Image Image

Configuration

默认配置

Various environment information

docker master 镜像

docker inspect zlmediakit/zlmediakit:master

// ...
            "Labels": {
                "org.opencontainers.image.created": "2025-01-20T10:00:36.195Z",
                "org.opencontainers.image.description": "WebRTC/RTSP/RTMP/HTTP/HLS/HTTP-FLV/WebSocket-FLV/HTTP-TS/HTTP-fMP4/WebSocket-TS/WebSocket-fMP4/GB28181/SRT server and client framework based on C++11",
                "org.opencontainers.image.licenses": "NOASSERTION",
                "org.opencontainers.image.ref.name": "ubuntu",
                "org.opencontainers.image.revision": "a27e9459f54122b09cb4df36cb8f33b9ca7ffd0f",
                "org.opencontainers.image.source": "https://github.com/ZLMediaKit/ZLMediaKit",
                "org.opencontainers.image.title": "ZLMediaKit",
                "org.opencontainers.image.url": "https://github.com/ZLMediaKit/ZLMediaKit",
                "org.opencontainers.image.version": "master"
            }
// ...

现象描述

您好,我正在开发 github.com/gowvp/gb28181 项目,在对接 webhook 的过程中遇到一点疑惑。

  1. rtmp 推流到平台
  2. 用 flv 协议播放
  3. webhook 的 on_play 回调 schema 值始终是 rtmp,我阅读文档后期望的值是 httpflv

文档中关于此参数的原文是 播放的协议,可能是 rtsp、rtmp、http,那播放用 http flv 协议,是不是应该 schema=http

如果播放 flv 的 on_play 中 schema=rtmp,那文档上的描述是否应该更正为 推流的协议,可能是 rtsp、rtmp... 等更准确的描述。

如何复现?

  1. rtmp 推流
  2. flv 协议播放
  3. 检查 on_play 回调的 schema 值

相关日志或截图

Image Image Image

配置

默认配置

各种环境信息

docker master 镜像

docker inspect zlmediakit/zlmediakit:master

// ...
            "Labels": {
                "org.opencontainers.image.created": "2025-01-20T10:00:36.195Z",
                "org.opencontainers.image.description": "WebRTC/RTSP/RTMP/HTTP/HLS/HTTP-FLV/WebSocket-FLV/HTTP-TS/HTTP-fMP4/WebSocket-TS/WebSocket-fMP4/GB28181/SRT server and client framework based on C++11",
                "org.opencontainers.image.licenses": "NOASSERTION",
                "org.opencontainers.image.ref.name": "ubuntu",
                "org.opencontainers.image.revision": "a27e9459f54122b09cb4df36cb8f33b9ca7ffd0f",
                "org.opencontainers.image.source": "https://github.com/ZLMediaKit/ZLMediaKit",
                "org.opencontainers.image.title": "ZLMediaKit",
                "org.opencontainers.image.url": "https://github.com/ZLMediaKit/ZLMediaKit",
                "org.opencontainers.image.version": "master"
            }
// ...

TRANS_BY_GITHUB_AI_ASSISTANT

xiongguangjie commented 1 week ago

这个只有http-flv 与 rtmp 的媒体源是一样的所以才有这个问题,这个我们想想怎么搞

xiongguangjie commented 1 week ago

这个的确是个疏漏, 我们后面修改一下

xiongguangjie commented 2 days ago

已经修复了,同时wiki也已经更新了