Closed mhelder closed 3 months ago
You need to run spotless locally - ./gradlew spotlessApply --no-configuration-cache
Done!
Unfortunately looks like there's failing tests
Ah sorry, my bad, I overlooked one existing test. Have pushed a fix, and this time ran the full test suite to make sure everything passes.
Can you push one more (empty) commit to re-trigger CI? Looks like github had an outage when you pushed
Thanks!
This PR fixes https://github.com/ZacSweers/MoshiX/issues/624.
KotlinPoet's ClassName.toString() does not yield a valid fully qualified path for e.g. nested classes, or when backticks are used in the package name to escape reserved keywords. Instead,
ClassName.reflectionName()
should be used for that.☝️ This is the only functional change.
The other changes in this PR are:
reflectionName()
was used. 👌Thanks to @sav007 for the hint in https://github.com/ZacSweers/MoshiX/issues/415#issuecomment-1513553223