Closed MangelMaxime closed 4 years ago
@Zaid-Ajaj Is it something we want to include in Femto scope?
I suppose this is something that can also happen when a package offer a free versionf hosted on npm and another one from a private server. FontAwesome does that for example.
I think this be solved by introducing a proper package hierarchy:
One package FontAwersome.Free
to support the free version which has a dependency on @fortawesome/fontawesome-free
One core package FontAwesome.SvgCore
which has dependency on @fortawesome/fontawesome-svg-core
and two more packages as descendants:
FontAwesome.FreeSolidSvgIcons
that depends on nuget:FontAwesome.SvgCore
and npm:@fortawesome/free-solid-svg-icons
FontAwesome.FreeRegularSvgIcons
that depends on nuget:FontAwesome.SvgCore
and npm:@fortawesome/free-regular-svg-icons
I think using a private npm registry server is out of scope. For those packages, you have to manually install the dependencies you see when you run femto
against the project
I don't think this is possible to have a proper package hierarchy in the case of FontAwesome.
Or at least not easily and without code duplication. This is probably a really special case because you can use icons from SVG, Font, JavaScript, React bindings, Vue bindings or all at once.
Let's just close this issue for now and see if others package has this need.
The only one know I can think about is Fable.React/Feliz if people want to use a react alternative.
About the pro registry, once the registry is configured you can simply do npm install @fortawesome/angular-fontawesome-pro
for example. But yes, let's keep it simple for now and try to improve adoption first. <-- I have some ideas for that and will make an issue for discussing it when ready.
The only one know I can think about is Fable.React/Feliz if people want to use a react alternative.
Feliz aims to support only React (Preact can be added using webpack aliases but it not priority of Feliz)
I have some ideas for that and will make an issue for discussing it when ready.
I am all ears :smile:
If we take Font Awesome as an example, there are several ways to use that package.
Use
@fortawesome/fontawesome-free
Use
@fortawesome/fontawesome-svg-core
and one of the svg package like@fortawesome/free-solid-svg-icons
,@fortawesome/free-regular-svg-icons
, etc.