search

Zaid-Ajaj / the-elmish-book

A practical guide to building modern and reliable web applications in F# from first principles
https://zaid-ajaj.github.io/the-elmish-book
Other
338 stars 51 forks source link

Add missing words, correct confusing wording, highlight the correct code line #150

Closed mjarosie closed 4 years ago

mjarosie commented 4 years ago

Hi Zaid,

Thanks for your amazing work! I've put some corrections as I've been going through the chapter, could you take a look? To be specific, I'm not sure if I got the following sentence correct:

This is sub-optimal because now the child programs suddenly know about the URLs of their parent program and probably other URLs about their sibling programs.

I've changed it to:

This is sub-optimal because now the child programs suddenly know about the URLs of their parent program and probably URLs of their sibling programs.

The last part of the original one is quite confusing. Did I get it right?

Also - the code line that's highlighted isn't the one that the paragraph describes - I fixed it as well.

Zaid-Ajaj commented 4 years ago

Thanks a lot @mjarosie, the changes look good!