refactor!: rewrite UI handling

ZakShearman / mc-tower-defence

Tower defence gamemode for minestom (EmortalMC)

GNU Lesser General Public License v2.1

11 stars 1 forks source link

refactor!: rewrite UI handling #77

Closed LooFifteen closed 6 months ago

ZakShearman commented 6 months ago

Started doing a review then realised I should probably bug test first.

Bugs:

[x] Current Queue in the mob GUI doesn't immediately update, have you made it schedule updating now?
[x] Upgrade troops GUI has all the mobs from the previous GUI chilling there.

I'll also submit a half completed review coz I might as well.

LooFifteen commented 6 months ago

Upgrade troops GUI has all the mobs from the previous GUI chilling there.

What is the intended behaviour? I've made this a tab-like system where you can upgrade a different mob, maybe it should be made more clear using an enchantment glint or similar?

ZakShearman commented 6 months ago

Bugs before I leave a review:

In the upgrade menu, when you click to upgrade a mob it still shows all the others mobs. If you meant this, it just looks confusing with them smushed up against each other.
Should be a back button in the upgrade menu. This was just never added before but should be now.

LooFifteen commented 6 months ago

I think the upgrade menu should be overhauled. Would it be a better idea to:

Get into a mob's upgrade menu by right-clicking it.
Have a back button in the bottom-right-hand corner.

ZakShearman commented 6 months ago

You probably should be able to get into upgrade by right clicking but ALSO a button to get into it.

The intended behaviour what it was before - it doesn't show the other troops. Keeping the other troops there makes the GUI extremely dense and hard to understand from a UX perspective.

It might work if there is spacing between all the mobs and the upgrading section.

LooFifteen commented 6 months ago

but ALSO a button to get into it

Having a separate upgrading UI that looks identical to the spawning UI is very confusing in my opinion.

ZakShearman commented 6 months ago

Having a separate upgrading UI that looks identical to the spawning UI is very confusing in my op

Hmm maybe yh. get rid of the intermediary GUI then yh.

LooFifteen commented 6 months ago

fixed 👍🏼

ZakShearman commented 6 months ago

New GUI looks good - only things:

We probably need a system to cancel an 'instant buy' of a mob (right click to unlock). Maybe if a user hasn't sent the mob yet and they've unlocked it in the past 10 seconds they can SHIFT + RCLICK to sell back that unlock.

We need to display the cost of unlocking a mob on that instant buy right click to unlock.

LooFifteen commented 6 months ago

TowerManager#determineDirection needs to be looked at/rewritten.