search

ZcashFoundation / zcash_script

Rust bindings to the ECC's zcash_script C++ library.
Apache License 2.0
1 stars 11 forks source link

Bump byteorder from 1.4.3 to 1.5.0 #99

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps byteorder from 1.4.3 to 1.5.0.

Commits
  • ec068ee 1.5.0
  • 0cfb84d cargo: a few small fixups
  • 62b0e31 changelog: add a note about it not being updated
  • dd41ee2 msrv: bump to Rust 1.60
  • 52cc70c safety: verify alignment requirements of floats vs ints
  • c0b6678 impl: remove unsafe code from read_uint and read_uint128 methods
  • 1e2d8b0 impl: eliminate unsafe_write_num_bytes
  • 368cb55 impl: refactor write_slice macro slightly
  • c01f0fe impl: eliminate special case checking target_endian
  • 3409ee1 perf: convert endianess while reading slice in a single pass
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
oxarbitrage commented 1 year ago

I think we should remain in the current 1.4.3 version here because zcashd did not upgraded.

In the zcash Cargo.toml they are in version 1: https://github.com/zcash/zcash/blob/v5.7.0/Cargo.toml#L46 which could allow us to upgrade but in their lock file they are using 1.4.3: https://github.com/zcash/zcash/blob/v5.7.0/Cargo.lock#L274

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.