[Bug]: Samurai Cooldown Tracking issue

Dezpyer commented 3 years ago

What are you trying to do?

Setting up Trackers for "Tsubame-gaeshi" and "Hissatsu: Senei"/"Hissatu: Guren"

What is the expected behaviour?

Tracking the Timers properly

What actually happened?

For "Hissatsu: Senei" "Hissatu: Guren" it only shows if u cast the spell which u are actually tracking. So if u are tracking Senei and casting Guren it doesnt show that the spell is on cooldown since they both sharing the same cd.

Tsubame is recasting ur last Iaijutsu (Higanbana, Tenka Goken, Midare Setsugekka) in an empowered form. Doesnt track cd if u use it.

Logs

No response

FFXIV Update

[X] I have confirmed that I have the latest version of Ravahn's FFXIV_ACT_Plugin, ngld's OverlayPlugin and cactbot (for the memory reading) are up to date.

Zeffuro commented 3 years ago

These skills are a bit special and are harder to keep track of. It's highly recommended you put skills like this on a real action that you move around for these special types of skills (just like procs on other jobs).

For Hissatsu: Senei and Hissatsu: Guren there is a way but requires you exporting your config as JSON and editing/adding the skills like so:

{
        "id": 7496,
        "name": "Hissatsu: Guren",
        "name_cn": "必杀剑·红莲",
        "name_de": "Hissatsu: Guren",
        "name_en": "Hissatsu: Guren",
        "name_fr": "Hissatsu : Guren",
        "name_kr": "필살검: 홍련",
        "enabled": true,
        "tts": true,
        "ttstype": 0,
        "job": "SAM",
        "level": 70,
        "duration": 0,
        "cooldown": 120,
        "type": "CustomCooldown",
        "icon": "https://xivapi.com/i/003000/003177_hr1.png",
        "color": "--filter-light-blue",
        "order": 3,
        "extra": {
          "charges": 0
        }
      },
      {
        "id": 16481,
        "name": "Hissatsu: Senei",
        "name_cn": "必杀剑·闪影",
        "name_de": "Hissatsu: Senei",
        "name_en": "Hissatsu: Senei",
        "name_fr": "Hissatsu : Sen'ei",
        "name_kr": "필살검: 섬영",
        "enabled": true,
        "tts": true,
        "ttstype": 0,
        "job": "SAM",
        "level": 72,
        "duration": 0,
        "cooldown": 120,
        "type": "CustomCooldown",
        "icon": "https://xivapi.com/i/003000/003178.png",
        "color": "--filter-light-blue",
        "order": 2,
        "extra": {
          "charges": 0,
          "shares_cooldown": 7496,
          "hide": true
        }
      },

I have currently no short term plans on adding custom logic to handle Tsubame / Iaijutsu so best to use the method I mentioned before.

Dezpyer commented 3 years ago

I found a solution for me Tsubame, required a bit of editing.

Might be useful for someone who tries the same

The cn, jp and kr are false not sure if they need tho. Also added Higanbana just in case even u dont use it.


  "id": 16486,
  "name": "Kaeshi: Setsugekka",
  "name_cn": "必杀剑·星眼",
  "name_de": "Kaeshi: Setsugekka",
  "name_en": "Kaeshi: Setsugekka",
  "name_fr": "Kaeshi: Setsugekkan",
  "name_jp": "必殺剣・星眼",
  "name_kr": "필살검: 성안",
  "enabled": true,
  "tts": true,
  "ttstype": "0",
  "job": "SAM",
  "level": 66,
  "duration": "0",
  "cooldown": "60",
  "type": "CustomCooldown",
  "icon": "https://xivapi.com/i/003000/003181.png",
  "color": "--filter-light-blue",
  "order": "9",
  "extra": {
    "charges": "0",
    "shares_cooldown": 16483,
    "hide": true
  }
},
{
  "id": 16485,
  "name": "Kaeshi: Goken",
  "name_cn": "必杀剑·星眼",
  "name_de": "Kaeshi: Goken",
  "name_en": "Kaeshi: Goken",
  "name_fr": "Kaeshi: Goken",
  "name_jp": "必殺剣・星眼",
  "name_kr": "필살검: 성안",
  "enabled": true,
  "tts": true,
  "ttstype": "0",
  "job": "SAM",
  "level": 66,
  "duration": "0",
  "cooldown": "60",
  "type": "CustomCooldown",
  "icon": "https://xivapi.com/i/003000/003181.png",
  "color": "--filter-light-blue",
  "order": "10",
  "extra": {
    "charges": "0",
    "shares_cooldown": 16483,
    "hide": true
  }
},
{
  "id": 16484,
  "name": "Kaeshi: Higanbana",
  "name_cn": "必杀剑·星眼",
  "name_de": "Kaeshi: Higanbana",
  "name_en": "Kaeshi: Higanbana",
  "name_fr": "Kaeshi: Higanbana",
  "name_jp": "必殺剣・星眼",
  "name_kr": "필살검: 성안",
  "enabled": true,
  "tts": true,
  "ttstype": "0",
  "job": "SAM",
  "level": 66,
  "duration": "0",
  "cooldown": "60",
  "type": "CustomCooldown",
  "icon": "https://xivapi.com/i/003000/003181.png",
  "color": "--filter-light-blue",
  "order": "11",
  "extra": {
    "charges": "0",
    "shares_cooldown": 16483,
    "hide": true
  }
}

Zeffuro commented 3 years ago

Ah nice, good to know that the general extra properties also solved a purpose for these. Thanks! :)

For completeness sake here are all the names in all languages for all abilities:

Name: "Kaeshi: Goken",
Name_de: "Kaeshi Goken",
Name_en: "Kaeshi: Goken",
Name_fr: "Kaeshi Goken",
Name_ja: "返し五剣",
Recast100ms: 600,
UrlType: "Action",
Name_cn: "回返五剑",
Name_kr: "반전오검",

Name: "Kaeshi: Higanbana",
Name_de: "Kaeshi Higanbana",
Name_en: "Kaeshi: Higanbana",
Name_fr: "Kaeshi Higanbana",
Name_ja: "返し彼岸花",
Recast100ms: 0,
UrlType: "Action",
Name_cn: "回返彼岸花",
Name_kr: "반전피안화",

Name: "Kaeshi: Setsugekka",
Name_de: "Kaeshi Setsugekka",
Name_en: "Kaeshi: Setsugekka",
Name_fr: "Kaeshi Setsugekka",
Name_ja: "返し雪月花",
Recast100ms: 300,
UrlType: "Action",
Name_cn: "回返雪月花",
Name_kr: "반전설월화",

How to find them? https://fakegaming.eu/ffxiv/spellname/index.php?name=SKILLNAMEHERE&type=action&lang=en This is the backend that looks up spells through my server and then merges it with the data at XIVAPI

Zeffuro / ZeffUI