ZeroQI / Lambda.bundle

Local Media Export, a reverse Plex 'Local Media Assets' agent to export metadata locally
GNU General Public License v3.0
134 stars 18 forks source link

Missing export items #4

Closed BrutuZ closed 5 years ago

BrutuZ commented 5 years ago

Having issues trying to export Episode NFO and Special Season's Poster and Fanart. Below is the file structure after refreshing metadata.

\<show>\fanart.jpg
\<show>\poster.jpg
\<show>\theme.mp3
\<show>\tvshow.nfo
\<show>\Season 00
\<show>\Season 00\<show>s00e04.mp4
\<show>\Season 01
\<show>\Season 01\Season01-fanart.jpg
\<show>\Season 01\Season01.jpg
\<show>\Season 01\<show>s01e01.mp4
\<show>\Season 01\<show>s01e02.mp4
\<show>\Season 01\<show>s01e03.mp4
\<show>\Season 01\<show>s01e04.mp4
\<show>\Season 01\<show>s01e05.mp4
\<show>\Season 01\<show>s01e06.mp4
\<show>\Season 01\<show>s01e07.mp4
\<show>\Season 01\<show>s01e08.mp4
\<show>\Season 01\<show>s01e08.nfo

Both seasons have custom posters set on Plex, yet season-specials-poster.jpg is missing. Only the show's last episode's NFO is being generated (the plugin expects each episode to be in its own folder?). This also happens with multiple regular seasons.

Suggestions:

ZeroQI commented 5 years ago

Episode NFOs bug confirmed, didn't code to save multiple in structure, was only testing single eps, didn't spot it until your bug report... This will handle ep NFOs correctly. Will have to correct other issues reported now, didn't have a look yet

BrutuZ commented 5 years ago

After this update all episodes have their corresponding NFO files and Season 00 (Specials) is parsed too. Sorry for the delayed feedback.

ZeroQI commented 5 years ago

@BrutuZ excellent. You reported and made me fix a big issue and i made more progress in 2 days tan in 3 weeks. Thank you.

BrutuZ commented 5 years ago

Just tested the latest commit (24f00df) and SeasonXX-fanart are still being copied as duplicates. Could be also related to the NFO issue that expected a specific folder structure?

As for the filename customization, it's not so much for the filename itself (although I did add the -poster suffix on the DefaultPrefs file) as it is for customizing the destination folder. For now I (and kodi) like to keep the images bundled in the series' root folder, but in the future would like to experiment other organization schemes, like a .metadata folder

ZeroQI commented 5 years ago

i followed https://support.plex.tv/articles/200220717-local-media-assets-tv-shows/ for location Coded to put the ep thumb/nfo with episode name, season media in season folder if exist otherwise series folder, so the import is done by local media assets agent. Seasonxx-poster.ext probably isn't loaded back by local media assets. an option to move all in another folder if located at the root (_metadata) but need to make the agent work fully first.

Could I please have the logs for SeasonXX-fanart still being copied as duplicates ? need to see if filenames are identical or have to compare pictures...

BrutuZ commented 5 years ago

Fixing before adding more features that can turn into more points of failure. Sounds very reasonable šŸ‘

Filenames are different (fanart.jpg and season01-fanart.jpg), the image is the same and so is the Plex URL (/library/metadata/245095/art/1537682488). Compare that perhaps?

Just in case:

ZeroQI commented 5 years ago

the season xml list only one when there is duplicate. It include the media id so checked its presence, easier... Please test new version and feedback any issue remaining

BrutuZ commented 5 years ago

Duplicate images solved too on 63197b2. All reported issues fixed šŸ‘