search

ZhengPeiRu21 / mod-individual-progression

AzerothCore Individual Progression Module
MIT License
118 stars 54 forks source link

Create dungeon_blackrock_depths.sql - fixes in BRD #380

Closed Grimfeather closed 1 month ago

Grimfeather commented 1 month ago

Related to: https://github.com/ZhengPeiRu21/mod-individual-progression/issues/357

I used: https://www.azerothcore.org/wiki/loot_template#groupid to find the correct values for Rockfist. Please have a look and confirm these values before merging. I set the drop chance to 0 because that's the same as the other items in GroupID 1 according to the wiki this will give Rockfist the same chance to drop as Bloodfist. it may need to be a lower chance, but then we have to update the chances of the other items in GroupID 1 as well. https://www.wowhead.com/classic/npc=9502/phalanx I think it would then have to be like this: Image2 But I'm not so sure the chances shown on wowhead are correct.

side note: the dark coffer event not working is an AzerothCore issue, it's questionable if it should be fixed by this mod.

I got the fix from TrinityCore. ( https://github.com/TrinityCore/TrinityCore/issues/6914 ) I tested it and it works just fine in AzerothCore as well.

Here I read about Rockfist. upvoted comment mentioning this item no longer drops in TBC (Patch 2.3.3) https://www.wowhead.com/wotlk/item=11743/rockfist#comments

Rockfist gets updated by this module in item_changes.sql but Phalanx did not have it in it's drop table.

ZhengPeiRu21 commented 1 month ago

Sorry for taking a while to merge this PR. Thank you for the fixes! I wasn't aware that Rockfist was removed from the drop table in TBC.

I agree it may be best to fix the Dark Coffer event upstream, but it doesn't hurt to have the fix included in the module for now. I can remove it once it gets fixed upstream. You may want to consider opening a PR for AC with the fix.