search

Zhuinden / flowless

[DEPRECATED] Based on Flow 1.0-alpha. To keep your life simple, use zhuinden/simple-stack instead.
Apache License 2.0
141 stars 7 forks source link

Should I even keep `preSaveViewState()` as part of the library? #17

Closed Zhuinden closed 7 years ago

Zhuinden commented 7 years ago

It's really just a hacky means of delegating before super.onSaveInstanceState() to fix the state persistence in the library https://github.com/ArthurHub/Android-Image-Cropper and set the image bitmap to null instead of serializing the picture to a Bundle.

This use-case is specific to the project, maybe it'd be best to remove it altogether and just move it to the project where I actually needed it.

Zhuinden commented 7 years ago

It makes more sense than calling onSaveInstanceState without a bundle (outside of onSaveInstanceState) as per https://github.com/Zhuinden/flowless/commit/4241d9b5216ae72106af7552b0468cb39e2e1e61