search

ZigEmbeddedGroup / microzig

Unified abstraction layer and HAL for several microcontrollers
zlib License
1.26k stars 102 forks source link

Port for WCH CH32V series (CH32V003, CH32V103, and CH32V203) #286

Closed nosuz closed 1 week ago

nosuz commented 2 weeks ago

I have added port modules and examples for WCH CH32V serires MPU. Examples programs can be built by make in examples/wch.

I am happy to be merged my work.

However, I have found the other Pull-Request #223 which supports CH32V003 is proposed. Should I merge this Pull-Request int my branch?

Thank you,

nosuz commented 1 week ago

Thank you for your kindly revew and sugestions. I have followed your all suggestions and updated my branch to integrate the chages in your main branch.

mattnite commented 1 week ago

@nosuz please rebase on main and fix conflicts

nosuz commented 1 week ago

@mattnite Thank you for your advice. I have rebased to your current main branch. And I have also changed build.zig files in the top and examples directories to add "wch/ch32".

mattnite commented 1 week ago

@nosuz thank you!

nosuz commented 1 week ago

@mattnite Thank you very much for merging my Pull-Request.

But I am sorry I found my examples fail to compile becase of the chnage by "Build system rewrite" #259. I am going to fix.

Should I mention in this Pull-Request tree when I finished my work, or should I create new Pull-Request?

mattnite commented 1 week ago

@nosuz No worries! I realized this may be the case. There's a few other issues that need fixing before the next release. I wanted to get all your good work in now, and then fix it up later when I had a couple patterns figured out for CI. Please make an additional PR.

nosuz commented 6 days ago

@mattnite Thank you for your advices. I am trying to fix this problem and will send a new PR when it is finished.