Zilliqa / zq2

Zilliqa 2.0 code base
Apache License 2.0
10 stars 0 forks source link

Don't use the faucet address as validator reward address #1618

Open DrZoltanFazekas opened 1 month ago

DrZoltanFazekas commented 1 month ago

In the current ZQ2 test networks, the bootstrap is a validator and it uses the faucet address as reward address. We should change it to use a "neutral" address like all other validators do.

JamesHinshelwood commented 1 month ago

Why? Not against doing this, just curious.

DrZoltanFazekas commented 1 day ago

My first thought was because it makes it harder to check the correctness of the faucet balance (e.g. I can't calculate how many times it was used based on its balance just as a hypothetical example) and the correctness or the rewards earned by the validator, if they are not sent to a separate account.

On a second thought, I'd start using the null address as reward address for the bootstrap because that is exactly what we will need for the guard nodes we will run with a deposit borrowed from the null address on mainnet i.e. they should not earn rewards.