search

ZiqiuZeng / pe

0 stars 0 forks source link

incorrect object deletion of sequence diagram on P.3, DG #10

Open ZiqiuZeng opened 1 year ago

ZiqiuZeng commented 1 year ago

Screenshot 2023-04-14 at 5.38.12 PM.png

The deletion of the Command object is not accurate, the lifeline of the Command object cannot terminate while it is still "interacting" with the CLIAlgo object.

nus-se-bot commented 1 year ago

Team's Response

This sequence diagram is correct because it terminates upon returning the flow of control to CLIAlgo. There are no method calls to command after the deletion.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: When the Command object is responsible for returning the flow of control, and is still executing code that interacts with the CLIAlgo object, it cannot be deleted until that code completes execution and the Command object goes out of scope.