Zoinkwiz / quest-helper

Helps with Quests.
BSD 2-Clause "Simplified" License
236 stars 415 forks source link

Cold War quest not filtered out with Attack skill filter #1829

Open Necromancer-code opened 3 weeks ago

Necromancer-code commented 3 weeks ago

Killing Icelords in the quest rewards 40 Attack xp. This means the quest should be filtered out with the Attack skill filter.

Probably a low priority fix, but should be quick.

Necromancer-code commented 3 weeks ago

In file:

src/main/java/com/questhelper/helpers/quests/coldwar/ColdWar.java

adding:

new ExperienceReward(Skill.ATTACK, 40));

to line 458

This looks like a solution, according to my 5 minutes of research.

pajlada commented 3 weeks ago

Good find & report - I suspect we will want to make an ExperienceReward that shows up with a special text in the sidebar

Necromancer-code commented 3 weeks ago

Sounds good!

Actually, the Desert Easy Diary requires you to open a Pyramid Plunder Sarcophagus that give 20 Strength xp, and isn't filtered out with the Strength skill filter. Seems like a similar situation. 👍