Zomis / FactorioMods

Various mods for the game Factorio
https://mods.factorio.com/mods/zomis
MIT License
15 stars 7 forks source link

update exploding-trees #55

Closed chayleaf closed 1 year ago

chayleaf commented 1 year ago

Side note, I think you should change the repository to not have the version number in the mod name. This will make the commit diffs way nicer.

Zomis commented 1 year ago

Thanks for the pull request.

I haven't bothered before about the version numbers in the mod names, even though I knew that they weren't needed. Because I built my Jenkinsfile to take care of the version updating, back in the day when the version number was required in the folder name.

Now I had a reason to update my Jenkinsfile though to also support mods without version number in folder name, thanks for that motivation :)

I have released a new version of the mod now, thanks!

Zomis commented 1 year ago

Btw... I can't believe someone is actually seriously playing with that mod 😂 I made it just for the fun of the quote.

chayleaf commented 1 year ago

I'm not actually playing with it, I just randomly tried it with SE installed lol

Zomis commented 1 year ago

@chayleaf That makes more sense. Thanks for the pull request anyway 😄

riven8192 commented 1 year ago

in control.lua i see this line: local position = get_random_position(box, 0.8, 0.5)

while the function only defines the 'box' parameter, so it ignores the 2nd and 3rd argument