Zuehlke / cookbook-elk-stack

0 stars 1 forks source link

Update cookbook structure to be more idiomatic #5

Closed tknerr closed 8 years ago

tknerr commented 8 years ago

This PR updates the structure of this repo to reflect the more idiomatic cookbook structure that would be also generated using chef generate cookbook .... (note that the earlier cookbook structure is valid too, but it's the one we found to be more optimal for developer VMs, but less optimal for cookbooks that represent server VMs)

So this PR:

$ rake -T
rake chefspec     # run chefspec examples
rake foodcritic   # run foodcritic lint checks
rake integration  # run test-kitchen integration tests
rake rubocop      # check Ruby code style with rubocop
rake unit         # run all unit-level tests

Still TODO:

/cc @damphyr @jahnf

tknerr commented 8 years ago

@damphyr @a-zen @jahnf this PR is now complete and ready for review.

Please ignore the failing CircleCI build for now -- it's a docker related issue and all integration tests are passing when run in VirtualBox. I will fix this later in a separate PR

a-zen commented 8 years ago

Very well done thank you very much. Sorry for the delay with the feedback.

tknerr commented 8 years ago

:+1: thanks for merging!