Closed tknerr closed 8 years ago
@damphyr @a-zen @jahnf this PR is now complete and ready for review.
Please ignore the failing CircleCI build for now -- it's a docker related issue and all integration tests are passing when run in VirtualBox. I will fix this later in a separate PR
Very well done thank you very much. Sorry for the delay with the feedback.
:+1: thanks for merging!
This PR updates the structure of this repo to reflect the more idiomatic cookbook structure that would be also generated using
chef generate cookbook ...
. (note that the earlier cookbook structure is valid too, but it's the one we found to be more optimal for developer VMs, but less optimal for cookbooks that represent server VMs)So this PR:
cookbooks/vm
to top level and gets rid of theupdate-vm.sh
scriptGemfile
to lock the gem environment so we are not dependent on a specific version of ChefDK and so that we can update individual gems if desired (runbundle install
to download / install them)Rakefile
to provide a common interface for running tasks and hiding the nitty gritty commandline parameters from the user (runrake -T
to list available tasks):.rubocop.yml
config and makes ruby level linting via rubocop pass (runrake rubocop
)rake foodcritic
).kitchen.yml
config to lock the Chef version, use chef zero, and make use of caching if vagrant-cachier plugin is installed. All tests are still passing. (runrake integration
)Vagrantfile
to use chef_zero + berkshelfStill TODO:
add circelci build integration(will be added in a separate PR)/cc @damphyr @jahnf