Zverik / every_door

A dedicated app for collecting thousands of POI for OpenStreetMap
https://every-door.app
ISC License
407 stars 35 forks source link

Way to replace an address node with an amenity #644

Open Zverik opened 1 year ago

Zverik commented 1 year ago

In some countries addresses reference entrances. So when an entrance is for a shop or amenity, it seems natural to not create a second node, but to replace the entrance address node with the shop, adding the address to it.

Currently one can create an amenity (tagging the address) and then delete the nearby address node, but that means the location of the address would be altered. One can also edit the address node and change its type to an amenity, but this feels weird, and possibly the address might be reset.

See this changesets and surrounding area for an example.

Related to #616: a shop may take up an entire building, and in this case tags might better go on the building contour.

Feels like it should be a checkbox somewhere — maybe between regular and extended field lists, and only for amenities.

tordans commented 1 year ago

Personally, I find this way of tagging very confusing. It also makes it easy to make errors. IMO in most cases the amenity should not be merged with the address. Once the shop is gone, it might get deleted but the address should stay. It is not a problem to have one address multiple times, each has it's own purpose. There are edge cases, of course, but those are special and not too often.

Good cases are IMO A:

B:

C:

D:

Merging the amenity/shop with entrance and address only makes sense to me in Case D where there is one building, all is this shop, all is this address. In this case, one might as well put it on the house-area.


In Berlin we have (A) and (B) depending on where you are, sometimes (C) and (D) when one shape is only one thing.

gdabski commented 10 months ago

I support making this possible, especially the case from #616. An example I recently came across a few times is adding power=substation tagging to a service building. This is a case when adding the tags to the outline seems even more natural than for a shop that takes up the entire building, but has been made even more difficult since #616 (you have to use the tag editor to manually add power=substation, then you can switch to micromapping mode to add more details).