search

Zylann / godot_voxel

Voxel module for Godot Engine
MIT License
2.72k stars 251 forks source link

VoxelStream.load_voxel_block() and .save_voxel_block() have a misleadingly named parameter #715

Open clarence112 opened 5 days ago

clarence112 commented 5 days ago

both VoxelStream.load_voxel_block() and VoxelStream.save_voxel_block() have a parameter named origin_in_voxels. Confusingly, it does not take the origin in voxel coordinates, but rather in block coordinates. Specifying (16, 16, 16) will return block (16, 16, 16), rather than the block containing position (16, 16, 16).

Zylann commented 5 days ago

Indeed, they take block coordinates. I changed that a while ago, but forgot to update parameter names. Will need to update that.

Zylann commented 4 days ago

Fixed in 9d99f0366616c9719e5a4ae31a7a246ba1dc616b