a1studmuffin / SpaceshipGenerator

A Blender script to procedurally generate 3D spaceships
Other
7.66k stars 437 forks source link

Fix:Comments in .py files #30

Open SahanChan opened 5 years ago

SahanChan commented 5 years ago

Gave some life to the python code by adding comments. ;-)

zircher commented 5 years ago

Just curious, has this been tested under 2.8?

SahanChan commented 5 years ago

Just curious, has this been tested under 2.8?

Yeah, it is tested, they are just comments. XD

ldo commented 2 years ago

My policy with comments is they should explain why you are doing something, rather than simply repeating what the code is doing.

For example, from my version:

def define_tex_coords_common() :
    # creates a node group that defines a common coordinate system
    # for all my image textures.
    ...

def define_hull_colour_common() :
    # creates a node group that applies the grunge factor to
    # an input colour to produce an output colour.
    ...

def define_normals_common() :
    # defines a node group for the normal-mapping texture to be used
    # across different hull materials.
    ...

etc, etc.

SahanChan commented 2 years ago

Yup you are right :))