search

aaFn / Bookmark-search-plus-2

Displays and filters bookmarks on search string, show parent folders. This is a Web Extension add-on version of the old "Bookmark search plus" XUL extension published by Alice0775, not working anymore in latest Firefox, and which was very useful.
117 stars 11 forks source link

No longer able to delete bookmarks #282

Closed ragkag closed 1 year ago

ragkag commented 1 year ago

For some reason, I am unable to delete bookmarks. Right-click>delete does nothing. Firefox 118.0.1, Bookmark-search_plus-2 2.0.118

aaFn commented 1 year ago

Hello @ragkag , still works perfect for me. Is that on any bookmark ?

I would suggest you do a "Reload from FF API" first in the options page, before retrying

ragkag commented 1 year ago

I did a “reload” then tried deleting 6 different bookmarks from different folders and none of them deleted. Nothing happened after I clicked delete.

As far as I know this was working. I don’t delete bookmarks often.

From: aaFn @.> Sent: Monday, October 9, 2023 4:25 PM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

Hello @ragkag https://github.com/ragkag , still works perfect for me. Is that on any bookmark ?

I would suggest you do a "Reload from FF API" first in the options page, before retrying

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1753976317 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7M45Q2SOJF3NEL4XW3X6R2SPAVCNFSM6AAAAAA5YXVWE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTHE3TMMZRG4 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7PFFODBHWDZLGQUIP3X6R2SPA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIROG72.gif Message ID: @. @.> >

ragkag commented 1 year ago

I also created a new folder and was not able to delete it either.

From: aaFn @.> Sent: Monday, October 9, 2023 4:25 PM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

Hello @ragkag https://github.com/ragkag , still works perfect for me. Is that on any bookmark ?

I would suggest you do a "Reload from FF API" first in the options page, before retrying

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1753976317 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7M45Q2SOJF3NEL4XW3X6R2SPAVCNFSM6AAAAAA5YXVWE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTHE3TMMZRG4 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7PFFODBHWDZLGQUIP3X6R2SPA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIROG72.gif Message ID: @. @.> >

aaFn commented 1 year ago

Ok strange, can you apply this procedure https://github.com/aaFn/Bookmark-search-plus-2/wiki#debugging-bsp2 to take some traces of what is happening when you try to delete 1 bookmark

and then post here the result of the trace ?

Thank you aaFn.

ragkag commented 1 year ago

I think I did what you asked. Strange that the only message I see is below. I actually did this twice with two different bookmarks with the same result. I only posted the

2nd one.

Uncaught (in promise) Error: No bookmarks found for the provided parentGuid undefined

From: aaFn @.> Sent: Tuesday, October 10, 2023 3:08 PM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

Ok strange, can you apply this procedure https://github.com/aaFn/Bookmark-search-plus-2/wiki#debugging-bsp2 to take some traces of what is happening when you try to delete 1 bookmark

and then post here the result of the trace ?

Thank you aaFn.

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1756261198 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7IRLU2RMHFAVCBXIPDX6W2LLAVCNFSM6AAAAAA5YXVWE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGI3DCMJZHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7L6GPAYPWI3DTMFV5LX6W2LLA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIVZVU4.gif Message ID: @. @.> >

ragkag commented 1 year ago

After I submitted what you asked for, I decided to try this:

            I went to View>Sidebar> and switched from “Bookmark search Plus2” to “Bookmarks” and I was then able to delete bookmarks and folders.

            I then switched back to “Bookmark search Plus2” and could NOT delete bookmarks.

From: aaFn @.> Sent: Tuesday, October 10, 2023 3:08 PM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

Ok strange, can you apply this procedure https://github.com/aaFn/Bookmark-search-plus-2/wiki#debugging-bsp2 to take some traces of what is happening when you try to delete 1 bookmark

and then post here the result of the trace ?

Thank you aaFn.

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1756261198 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7IRLU2RMHFAVCBXIPDX6W2LLAVCNFSM6AAAAAA5YXVWE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGI3DCMJZHA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7L6GPAYPWI3DTMFV5LX6W2LLA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIVZVU4.gif Message ID: @. @.> >

aaFn commented 1 year ago

I am out in a location with very little bandwidth, will try to think about this, but the message with ParentGuid is indeed strange. I may create a special debug version for you to investigate, but then that means on week of OOctober 23rd when I am back. Hope this is ok.

ragkag commented 1 year ago

No problem. I appreciate you trying to fix it. Creating a special debug version will take a lot of your time. Unless you have had this

Issues with others I’m good with the way it is. I can still delete bookmarks using the technique I described in my other email.

Your Bookmarks search plus 2 has been a godsend for me. I have essential tremor in my mouse hand and I was continually moving

bookmarks to other folders without even knowing it. You’ve made it possible to find those moved bookmarks.

Thank you. And if you decide to create the debug version I’ll be glad to test it for you. Stay safe.

Bob Gregory

From: aaFn @.> Sent: Tuesday, October 10, 2023 3:43 PM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

I am out in a location with very little bandwidth, will try to think about this, but the message with ParentGuid is indeed strange. I may create a special debug version for you to investigate, but then that means on week of OOctober 23rd when I am back. Hope this is ok.

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1756310352 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7JXDE5673PGWZRADBTX6W6NNAVCNFSM6AAAAAA5YXVWE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJWGMYTAMZVGI . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7MZKD4OJFN526CN4DDX6W6NNA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIV4VVA.gif Message ID: @. @.> >

aaFn commented 1 year ago

One more thing, could you confirm if in the BSP2 options page you enabled or disabled the BSP2 trash ?

The option is called "Create & use BSP2 trash folder ..." in the section "Bookmark history & undo/redo"

ragkag commented 1 year ago

Yes, I do have this option turned on. Just an FYI, I have a laptop with the same OS and Firefox versions and deleting bookmarks works fine.

I tried clearing/disabling/enabling the trash folder but still can’t delete anything. ???

From: aaFn @.> Sent: Thursday, October 12, 2023 1:58 AM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

One more thing, could you confirm if in the BSP2 options page you enabled or disabled the BSP2 trash ?

The option is called "Create & use BSP2 trash folder ..." in the section "Bookmark history & undo/redo"

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1759120007 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7JCGBL2URM2AJKABJLX66PIBANCNFSM6AAAAAA5YXVWEY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7MDMTHD3NCRSW37ENDX66PIBA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTI3IFIO.gif Message ID: @. @.> >

ragkag commented 1 year ago

A little more info. I tried to clear the trash folder (about 30+ bookmarks) but it never cleared. If I disable the trash folder, deletions work fine.

From: aaFn @.> Sent: Thursday, October 12, 2023 1:58 AM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

One more thing, could you confirm if in the BSP2 options page you enabled or disabled the BSP2 trash ?

The option is called "Create & use BSP2 trash folder ..." in the section "Bookmark history & undo/redo"

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1759120007 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7JCGBL2URM2AJKABJLX66PIBANCNFSM6AAAAAA5YXVWEY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7MDMTHD3NCRSW37ENDX66PIBA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTI3IFIO.gif Message ID: @. @.> >

aaFn commented 1 year ago

Interesting .. so the problem is "Move to trash", and only on your specific instance. That points to a data problem tied to the "hidden" BSP2 trash folder, a priori. Maybe not well recognized because of its name, or several of them created in past, or not at its place ..

When you look at the native FF bookmarks sidebar, how many "BSP2 trash folder for undo of.." do you see ? Is it / are they under "Other Bookmarks" ? Or somewhere else ?

Note: you can also make it visible in BSP2, by ticking the corresponding option in the "Traces / debug" sectoin of the BSP2 option page.

ragkag commented 1 year ago

When you look at the native FF bookmarks sidebar, how many "BSP2 trash folder for undo of.." do you see ? Is it / are they under "Other Bookmarks" ? Or somewhere else ?

If I understand you correctly, using the native FF Bookmarks sidebar I do NOT see the "BSP2 trash folder for undo of..".

If using BSP2, I see it under “Other Bookmarks”. There are about 30+ bookmarks within the folder. A few are duplicated.

From: aaFn @.> Sent: Friday, October 13, 2023 1:58 AM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

Interesting .. so the problem is "Move to trash", and only on your specific instance. That points to a data problem tied to the "hidden" BSP2 trash folder, a priori. Maybe not well recognized because of its name, or several of them created in past, or not at its place ..

When you look at the native FF bookmarks sidebar, how many "BSP2 trash folder for undo of.." do you see ? Is it / are they under "Other Bookmarks" ? Or somewhere else ?

Note: you can also make it visible in BSP2, by ticking the corresponding option in the "Traces / debug" sectoin of the BSP2 option page.

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1761074370 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7OW3KSYL4RNPPKT3IDX7DX73ANCNFSM6AAAAAA5YXVWEY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7LW4LWBQPJYUR2WU7LX7DX73A5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTI67OME.gif Message ID: @. @.> >

aaFn commented 1 year ago

If I understand you correctly, using the native FF Bookmarks sidebar I do NOT see the "BSP2 trash folder for undo of..".

Wow, that is not normal ! That would mean a parent - child relationship is broken in the FF bookmarks database ..

You should see it right under “Other Bookmarks”, like in BSP2 when you make it visible by ticking the corresponding option in the "Traces / debug" section.

If that is not the case, then a corruption made its way in the FF DB, and the best way to cure it should be, in this order:

  1. While the BSP2 trash folder is visible in BSP2 (by ticking the corresponding option in the "Traces / debug" section)
  2. Untick the option "Create & use BSP2 trash folder ..." in "Bookmark history & undo/redo" section
  3. This will delete the BSP2 trash folder and all its content (you should be able to move what you want below it to somewhere else before doing so, so that you can keep them if you want)
  4. It won't appear anymore in BSP2
  5. It shouldn't appear either in the FF native bookmark sidebar
  6. Tick again the option "Create & use BSP2 trash folder ..." in "Bookmark history & undo/redo" section
  7. This will recreate it, empty
  8. It should now appear also in the FF native bookmark sidebar
  9. Try a few "delete" = the bookmarks you delete should move into the BSP2 trash .. and you can do undo/redo as needed.
  10. When all ok (I hope), you can hide the BSP2 trash folder in BSP2 (by unticking the corresponding option in the "Traces / debug" section)
  11. It will still be visible in the FF native bookmark sidebar

Let me know how things go .. 🤞

ragkag commented 1 year ago

After step 4 below, the BSP2 trash folder still shows, with bookmarks in it. I didn’t go any further. Should I try to manually delete it?

From: aaFn @.> Sent: Friday, October 13, 2023 10:03 PM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

If I understand you correctly, using the native FF Bookmarks sidebar I do NOT see the "BSP2 trash folder for undo of..".

Wow, that is not normal ! That would mean a parent - child relationship is broken in the FF bookmarks database ..

You should see it right under “Other Bookmarks”, like in BSP2 when you make it visible by ticking the corresponding option in the "Traces / debug" section.

If that is not the case, then a corruption made its way in the FF DB, and the best way to cure it should be, in this order:

  1. While the BSP2 trash folder is visible in BSP2 (by ticking the corresponding option in the "Traces / debug" section)
  2. Untick the option "Create & use BSP2 trash folder ..." in "Bookmark history & undo/redo" section
  3. This will delete the BSP2 trash folder and all its content (you should be able to move what you want below it to somewhere else before doing so, so that you can keep them if you want)
  4. It won't appear anymore in BSP2
  5. It shouldn't appear either in the FF native bookmark sidebar
  6. Tick again the option "Create & use BSP2 trash folder ..." in "Bookmark history & undo/redo" section
  7. This will recreate it, empty
  8. It should now appear also in the FF native bookmark sidebar
  9. Try a few "delete" = the bookmarks you delete should move into the BSP2 trash .. and you can do undo/redo as needed.
  10. When all ok (I hope), you can hide the BSP2 trash folder in BSP2 (by unticking the corresponding option in the "Traces / debug" section)
  11. It will still be visible in the FF native bookmark sidebar

Let me know how things go .. 🤞

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1762551652 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7P5IHBT2ULOL3NZH4DX7IFFRANCNFSM6AAAAAA5YXVWEY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7L544CMYAJFVJPNTK3X7IFFRA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTJBZTWI.gif Message ID: @. @.> >

aaFn commented 1 year ago

Ok, yes, if the delete action is enabled on it in BSP2 (which would mean it is no more recognized as the BSP2 trash folder, and so it should be processed like a normal folder), then try to delete it,

If the deletion is working, then you can continue with steps 5 and so on ..

Let me know the results.

ragkag commented 1 year ago

Well, this is what happened:

  1. With the BSP2 trash folder option disabled, I attempted to delete the BSP2 trash folder by right-clicking it but there was no “Delete” option in the context menu.

  2. I then went back to the native FF bookmarks and in the “Other Bookmarks” folder the BSP2 trash folder and all my previous “Other” items were gone EXCEPT for

                  two identically named bookmarks that I had previously saved.

  3. I was able to delete the two identically named bookmarks.

  4. I then enabled BSP2, went to options, and enabled the trash folder.

  5. I could now see the BSP2 trash folder and I can now delete bookmarks again, and they do go to the trash folder.

  6. Case closed.

Thanks for the help. Have no idea what happened. Not sure how I got two identically named bookmarks in my “Other” bookmarks section. Can you have two of the same

named bookmarks if they are pointing to different URLs?

Enjoy the rest of your weekend

From: aaFn @.> Sent: Saturday, October 14, 2023 11:59 AM To: aaFn/Bookmark-search-plus-2 @.> Cc: ragkag @.>; Mention @.> Subject: Re: [aaFn/Bookmark-search-plus-2] No longer able to delete bookmarks (Issue #282)

Ok, yes, if the delete action is enabled on it in BSP2 (which would mean it is no more recognized as the BSP2 trash folder, and so it should be processed like a normal folder), then try to delete it,

If the deletion is working, then you can continue with steps 5 and so on ..

Let me know the results.

— Reply to this email directly, view it on GitHub https://github.com/aaFn/Bookmark-search-plus-2/issues/282#issuecomment-1763065380 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52MF7IJKMWDJDL2TARNJGTX7LHFZANCNFSM6AAAAAA5YXVWEY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52MF7MJRX3OPU7GRYNIF63X7LHFZA5CNFSM6AAAAAA5YXVWE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTJCY7CI.gif Message ID: @. @.> >

aaFn commented 1 year ago

Ok, great that you are functional again.

That doesn't explain why the corruption occurred. It is normally not possible to lose the parent of a bookmark, and there is no way to force it through the API. However, I did get reports in the past of such things - not because of BSP2, since some of those reports pre-date the first version of BSP2, and BSP2 was able to find them and then allowed to reattach them by moving them to a new parent -, but obviously this happens. Unfortunate that in this case it happened on the BSP2 trash folder itself .. which makes things more complex to handle since I protect the BSP2 trash folder from BSP2 user manipulations to avoid bad accidents (maybe I should add an option to unprotect it, for handling such extreme cases ..).

Anyway, hopefully this won't come back, but if that ever does, let me know. Thank you, aaFn.

Gitoffthelawn commented 1 year ago

If any of the Firefox behaviour can be accurately described (or even better, replicated), I think it would make a very worthy issue report on: https://bugzilla.mozilla.org

elandorr commented 11 months ago

@Gitoffthelawn You closed it already, but I have the same problem. Deleted and re-enabled trash, refreshed from ff. Even with 'traces' enabled the console has nothing. But I found that having the firefox bookmark manager window open allows BSP2 to delete for some reason?!

This bugs very randomly, but right now, 100% of the time without this window open.

aaFn commented 11 months ago

Hello @elandorr, so like @ragkag above, do you still see the BSP2 trash folder under "Other bookmarks" in BSP2 when you do the following:

And not sure what the FF bookmark manager window can do here to alter the BSP2 behavior, that does not seem to make any sense .. 😞

elandorr commented 11 months ago

@aaFn If I do this, the checkbox is disabled and the trash folder is not visible under "other" in BSP2 anymore: image

Yes it's weird behavior. "Fiddling with it" sometimes makes it work. This has been broken for at least several months and I started just opening the FF manager window. Then I decided to do a search and found this thread.

I should probably mention this is FF 115 ESR. But usually the ESR is more stable, not less :)

Edit: Recently, BSP2 also does not react to changes made inside the FF manager. Or when you change something using the star icon in the bar. A restart "usually" fixes this.

aaFn commented 11 months ago

A bit weird indeed, and not the least about FF manager modifications not appearing live in BSP2 !!

By "refreshed from ff" in your first post above, did you mean pressing the button to "Reload all bookmarks from FF" in the BSP2 options ? If not, what did you mean ? And what happens when you press that button, do the problems still remain ?

(btw, is that the latest FF ESR 115.6.0 that you have, or an earlier version ?)

elandorr commented 11 months ago

Yes that one. If I change something in the FF manager and press it, BSP2 displays the changes.

works fine. I assume Mozilla broke something. They recently broke the Thunderbird add-ons yet again.

Now that I think of it, I should probably do an export and back up the bookmarks before some real corruption occurs :smiley:

(btw, is that the latest FF ESR 115.6.0 that you have, or an earlier version ?)

115.5.0 on Linux but on next reboot it'll be .6. I can reboot earlier than expected and try if you think .6 changes anything.

aaFn commented 11 months ago

Ok, let's say no hurry to get to the next version for now. One more thing to make sure I understand:

Or so you have different symptoms ?

elandorr commented 11 months ago

When you add, modify, move .. a bookmark in BSP2, that works fine, whether the BSP2 trash folder is enabled or not, correct ?

Yes, I did not touch that setting ever before you mentioned it. It doesn't seem to make a difference, maybe it's slower if enabled, but that could be random.

When you delete a bookmark in BSP2, and the BSP2 trash folder is disabled, this works also, correct ?

Yes, right now at least.

It is when you delete in BSP2 while the BSP2 trash folder is enabled that things do not happen, still correct ?

Unfortunately the answer is "sometimes". The only correlation I noticed is that fiddling with the FF manager helps. 9/10 times that works, if not, an additional "reload from FF" does. The Mozilla panel always let me delete/move/rename so far and after that BSP2+reload works.

Other observation: A disable/re-enable of the entire BSP2 does not change the state.

Maybe if I have some time I'll make a new profile and try to get a broken state to upload, but it's so random, it's unlikely to happen just when you want it.

Yesterday it was 100% broken, after using the FF manager today it works again. Sorry :/ Don't know how to get more debug info.

Happy new year in advance!

aaFn commented 11 months ago

Ok, I just tested under ESR 115.5.0, all works fine on this side .. so there is nothing I can investigate. I published a new version of BSP2, 2.0.121, to do some cleaning of unhomed BSP2 trash folders, or duplicates, in case something went wrong in the past, when disabling the BSP2 trash.

So can you update your BSP2 instance to 2.0.121, then disable the BSP2 trash option, and then exit from Firefox (this last step is important) ? And then restart Firefox, and go to the BSP2 options and re-enable the BSP2 trash option. That should at least address the case that @ragkag met, and hopefully yours also.

Let me know.

elandorr commented 11 months ago

@aaFn I'll update and let you know if the bug is absent in the next little while. We'll have to try live and see :)

Thanks for your effort

aaFn commented 11 months ago

Fyi, I uploaded a new version 2.0.122 with improved handling of diverse error cases on the BSP2 trash :

With that, I hope this should cure all odd cases around the BSP2 trash .. let me know how that goes on your side after you update to the latest version.

elandorr commented 11 months ago

@aaFn Since your last update and a restart deleting works reliably! Could be random luck, however. If it happens again in the next months I'll try to think of posting again.

I noticed something else you may want to know: If you bookmark a lot of tabs at once and have favicon download enabled, it'll freeze the rest of Firefox until it's done. Not a big deal, but noteworthy.

aaFn commented 11 months ago

Ok, thank you, let me know indeed if that comes back. Note: I do not have the symptom you mention on bookmarking a lot of tabs and freeze during favicon download, but I'll keep an eye watching.