search

aadsm / jsmediatags

Media Tags Reader (ID3, MP4, FLAC)
Other
738 stars 128 forks source link

Added more FLAC tag fields #138

Closed FritzHeiden closed 3 years ago

FritzHeiden commented 3 years ago

The current implementation of the FLACTagReader only implements tag fields provided by the specification. However, using common tag editors it is still possible to add tags for album artist, year and disc number. With these changes, the FLACTagReader will read those tags as well.

aadsm commented 3 years ago

(It seems that I've stopped getting PR mails from this repo, so sorry for only looking into this now)

I feel bad for rejecting this but I'm not going to accept because I want all the different types to have the exact same shortcuts so that people don't need to do different code depending on the media tag type. I hope it makes sense to you.

FritzHeiden commented 3 years ago

Thanks for looking at my PR! As far as I understand what bothers you with my changes is the format in which the new tags are returned. From your documentation I get this structure:

{
  type: <the tag type: ID3, MP4, etc.>
  tags: {
    <shortcut name>: <points to a tags data>
    <tag name>: {
      id: <tag name>,
      data: <the actual tag data>
    }
  }
}

If you would consider taking another look at my PR I would adjust my changes accordingly