search

aadsm / node-id3

Get music metadata from buffers and files.
Other
74 stars 86 forks source link

Get picture for .mp3 #2

Closed Roland1975 closed 11 years ago

Roland1975 commented 11 years ago

I can get the picture for .m4a files. However it seems that getting picture for .mp3 doesn't work.

id3_3v2.get('picture')

returns null

Did I miss something?

aadsm commented 11 years ago

This project is in copyright violation as far as I am able to understand, I just created a fork at the time as evidence of the issues I pointed out here: https://github.com/aadsm/node-id3/issues/1 Since then the author of the module has closed my issue and removed github issues from his original project.

tim-smart commented 11 years ago

From memory I transferred all ownership back over to you (hence why it seems my issue page disappeared)

This module probably needs to be written from scratch to make full use of Node's binary API's and string {en|de}coding, something I probably won't have time for ;)

aadsm commented 11 years ago

Yes, I understood that after I checked what was going on with the repositories, thank you for the clarification :-) And I completely agree with you on the best way to implement it.